Skip to content

Conversation

@rysweet
Copy link
Owner

@rysweet rysweet commented Nov 25, 2025

Summary

  • Adds new multi-repo skill for cross-repo coordination
  • Tracks dependency graphs between repositories
  • Manages linked PRs that should merge together
  • Detects breaking changes affecting dependents
  • Determines correct merge order

Part of Issue #1611 (Enhancement 7)

Files Added

  • .claude/skills/multi-repo/SKILL.md
  • .claude/skills/multi-repo/README.md
  • .claude/data/multi-repo/dependencies.yaml
  • .claude/data/multi-repo/linked-prs.yaml

How to Use

Triggers: 'multiple repositories', 'cross-repo', 'linked PRs', 'atomic changes'

🤖 Generated with Claude Code

Add new skill for multi-repository coordination:
- Tracks repository dependency graphs
- Manages linked PRs across repos
- Coordinates atomic cross-repo changes
- Detects breaking changes affecting dependents
- Determines correct merge order (topological)

Part of Issue #1611 Enhancement 7

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@rysweet
Copy link
Owner Author

rysweet commented Nov 25, 2025

Code Review for multi-repo Skill

User Requirement Compliance: Met

The PR fulfills the stated goal of adding a multi-repository orchestration skill for cross-repo coordination.


Philosophy Compliance: 8/10

Strengths:

  • Ruthless Simplicity: Uses YAML-based dependency graph (no database required) - aligns perfectly with "no unnecessary complexity"
  • Zero-BS Implementation: All 5 core operations are documented with concrete processes and examples
  • Modular Design: Self-contained skill with clear boundaries and optional PM Architect integration

Minor Concerns:

  • The skill mentions integration with "worktree manager agent" and "PM Architect" but these are soft references, not hard dependencies - this is actually good

Strengths

  1. Well-Structured Documentation: SKILL.md is comprehensive (297 lines) with clear sections for When to Use, Core Operations, Examples, and Limitations. README.md provides a clean quick-start guide.

  2. YAML Templates are Production-Ready: The dependencies.yaml and linked-prs.yaml templates include helpful comments showing exact format, field meanings, and realistic examples. Users can copy-paste and modify.

  3. Clear Use Case Boundaries: The AVOID FOR section explicitly lists when NOT to use this skill (single-repo changes, forking, docs-only changes), preventing misuse.


Issues Found

  1. MINOR - Missing version field in frontmatter pattern

    • Location: .claude/skills/multi-repo/SKILL.md line 3
    • The skill has version: 1.0.0 but pm-architect skill omits version. Both patterns exist in codebase, so this is acceptable but inconsistent.
    • Impact: Low - cosmetic inconsistency
    • Violates User Requirement: No
  2. MINOR - No explicit confirmation_required for destructive operations

    • Location: .claude/skills/multi-repo/SKILL.md line 14
    • The skill sets confirmation_required: false but Operation 5 (Coordinate Merge Sequence) performs merges which are destructive.
    • Impact: Low - merges require user action anyway via gh CLI
    • Recommendation: Consider noting in docs that merge operations should prompt user confirmation
  3. MINOR - Circular dependency handling

    • Location: .claude/skills/multi-repo/SKILL.md line 199
    • States "Circular dependencies: Error (should not exist in healthy graph)" but doesn't specify HOW to detect or report this.
    • Impact: Low - error case documentation
    • Recommendation: Add brief note about detection method (topological sort failure)

Recommendations

  1. Consider adding a simple validation command: "Validate dependency graph" operation that checks for cycles, missing repos, and orphaned dependencies would be valuable.

  2. Examples are solid but could show failure scenarios: The examples show happy paths. A brief example of what happens when breaking change detection finds issues would be helpful.

  3. Token budget seems reasonable: 2500 tokens for a skill with 5 core operations and YAML templates is appropriate.


Verdict

[x] Approved - Ready to merge

The skill follows amplihack philosophy, provides clear documentation, and adds genuine value for multi-repo coordination. The minor issues identified are documentation enhancements rather than blocking concerns. The YAML template approach is simple and effective.


Review Scores

Criteria Score
User Requirement Compliance 10/10
Philosophy Compliance 8/10
Simplicity 9/10
Modularity 9/10
Clarity 9/10
Overall 9/10

Bot Review by Claude Code Reviewer Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants