Skip to content

Raise exception on not-implemented @setting(setter) #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 4 commits into from
Nov 10, 2022
Merged

Raise exception on not-implemented @setting(setter) #1591

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9ea799
Warn for setter not implemented
starkillerOG Nov 9, 2022
07388db
Update miio/devicestatus.py
starkillerOG Nov 9, 2022
36f2dbe
fix black
starkillerOG Nov 9, 2022
d4d3c33
Merge branch 'master' into setter_input
starkillerOG Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion miio/devicestatus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,11 @@ def decorator_setting(func):
qualified_name = str(func.__qualname__)

if setter is None and setter_name is None:
raise Exception("Either setter or setter_name needs to be defined")
raise Exception("setter_name needs to be defined")
if setter_name is None:
raise NotImplementedError(
"setter not yet implemented, use setter_name instead"
)

common_values = {
"id": qualified_name,
Expand Down