Skip to content

Add the source field to MiotProperty #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 2 commits into from
Aug 19, 2025
Merged

Add the source field to MiotProperty #2037

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17e501d
Adds the source field to allow xiaomi.fan.p76 to function over generi…
flipper Aug 4, 2025
25f8529
Update miot_models.py
flipper Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion miio/miot_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ class MiotProperty(MiotBaseModel):
choices: Optional[list[MiotEnumValue]] = Field(alias="value-list")
gatt_access: Optional[list[Any]] = Field(alias="gatt-access")

source: Optional[int] = None

# TODO: currently just used to pass the data for miiocli
# there must be a better way to do this..
value: Optional[Any] = None
Expand All @@ -238,7 +240,10 @@ def pretty_value(self):

if self.choices is not None:
# TODO: find a nicer way to get the choice by value
selected = next(c.description for c in self.choices if c.value == value)
selected = next(
(c.description for c in self.choices if c.value == value),
self.choices[0],
Copy link
Owner

@rytilahti rytilahti Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that the reported 1 is for the index in the available choices?

Copy link
Contributor Author

@flipper flipper Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be. But the app didn't parse that 1 index as a value. So unsure what happened.
The miot protocol works in mysterious ways

Copy link
Owner

@rytilahti rytilahti Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if you want to test it with different values on your device to confirm the behavior, it could be interesting. Otherwise, I would avoid changing the behavior here now, as it feels like a firmware bug on your device.

Copy link
Contributor Author

@flipper flipper Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if you want to test it with different values on your device to confirm the behavior, it could be interesting. Otherwise, I would avoid changing the behavior here now, as it feels like a firmware bug on your device.

Yeah it does sound like a firmware bug. Would it be better if it returned None instead?

)
current = f"{selected} (value: {value})"
return current

Expand Down
Loading