Fix(aspects): complete list of aspects with missing ones and add a few minor aspects#33
Open
minaylosd wants to merge 2 commits intoryuphi:masterfrom
Open
Fix(aspects): complete list of aspects with missing ones and add a few minor aspects#33minaylosd wants to merge 2 commits intoryuphi:masterfrom
minaylosd wants to merge 2 commits intoryuphi:masterfrom
Conversation
Previously, each orb's width was halved, which caused result discrepancies with other sources. This update improves calculation accuracy, fixing the resulting list of aspects.
Added missing minor aspects to the list. Replaced Huber orbs with another set that includes values for minor aspects. The resulting aspects list now matches astro.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some aspects listed in other sources were missing due to halved orbs sizes.
Calculations were updated to return the correct list of aspects, and a few minor aspects were added.
Addresses #32