Develop by rzeldent · Pull Request #89 · rzeldent/esp32-flightradar24-ttgo

rzeldent · 2026-01-11T15:23:17Z

Formatting non latin characters

* Update main.yml * Bump actions/checkout from 4 to 5 (#72) Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from 5 to 6 (#73) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 4 to 5 (#74) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 5 to 6 (#75) Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/cache from 4 to 5 (#76) Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 5 to 6 (#77) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update GitHub Actions workflow to use stable versions of actions * Fix vertical_speed_metric conversion from ft/min to m/min (#79) * Initial plan * Fix vertical_speed_metric to use FT_TO_M conversion Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com> * Fix artifact name and path in firmware archive step * [WIP] Update GitHub Actions workflow for separate targets and releases (#81) * Initial plan * Update GitHub Actions workflow to use matrix strategy and fix release issues Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com> * Improve cache invalidation by including platformio.ini hash in cache key Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com> * Refactor GitHub Actions workflow to simplify artifact handling and update Python version * Fix artifact download pattern in GitHub Actions workflow * Refactor firmware upload steps in GitHub Actions workflow to improve clarity and accuracy * Fix firmware renaming step in GitHub Actions workflow to use 'mv' instead of 'cp' * Add strategy matrix for release job in GitHub Actions workflow * Refactor release job in GitHub Actions workflow to use pattern matching for artifact downloads and uploads * Fix artifact download and upload patterns in GitHub Actions workflow to match all firmware files * Refactor release job in GitHub Actions workflow to simplify file handling for artifact uploads * Bump actions/checkout from 4 to 6 (#82) Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/download-artifact from 4 to 7 (#83) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 4 to 6 (#84) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from 5 to 6 (#85) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor airline and airport lookup functions to simplify bsearch usage - Updated the lookup_airline function to directly pass the ICAO code to bsearch instead of creating a key structure. - Modified the comparison function in bsearch to compare the ICAO code directly with the airline_t structure. - Similarly, updated the lookup_airport function to pass the IATA code directly to bsearch and adjusted the comparison function accordingly. * Update branch filter to allow all branches in CI workflow * Refactor country representation and update flight display logic - Replaced individual country constants with a consolidated array of country structures in countries.cpp. - Introduced a new function `get_country` to retrieve country details based on country code. - Updated the flight display logic in main.cpp to utilize the new country structure, improving readability and maintainability. - Adjusted logging and image handling for airline and airport country information to reflect the new structure. * Refactor code structure for improved readability and maintainability * Fix aircraft struct: rename 'description' to 'aircraft_type' for clarity * Refactor airport struct for improved clarity and maintainability * Implement feature X to enhance user experience and optimize performance --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: rzeldent <7620231+rzeldent@users.noreply.github.com>

…ar24-ttgo into develop

…inter dereference

…ar24-ttgo into develop

…g and adjust platformio.ini to set default environment

Copilot

Pull request overview

This pull request adds support for formatting non-Latin characters (e.g., accented characters) to their ASCII equivalents for display compatibility. It introduces a new format_to_latin() function and applies it to airline and airport names, fixes vertical speed unit abbreviations, adds latitude/longitude range display to the "no flights" screen, and makes minor UI alignment adjustments.

Changes:

Added format_latin.h header with UTF-8 to ASCII character conversion function
Applied character formatting to airline and airport name displays
Corrected vertical speed units from "m/m" to "m/min" and "ft/m" to "ft/min"
Added latitude/longitude range display on the "no flights" screen
Minor UI alignment adjustments and platformio configuration cleanup

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
include/format_latin.h	New header file implementing UTF-8 to ASCII character conversion with support for common Latin diacritics
src/main.cpp	Integrated format_to_latin() for airline/airport names, fixed vertical speed units, added lat/lon range display, adjusted UI alignments
platformio.ini	Added default environment configuration, removed hardcoded upload port settings
README.md	Updated history with recent changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main.cpp

Copilot · 2026-01-11T15:28:32Z

include/format_latin.h

+        }
+        else
+        {
+            // ASCII character, copy as-is else // Invalid UTF-8, replace with ?


The comment on this line is malformed. It appears to have two separate comments merged into one: "// ASCII character, copy as-is else // Invalid UTF-8, replace with ?". This should be split into two separate lines or rewritten for clarity.

Suggested change

// ASCII character, copy as-is else // Invalid UTF-8, replace with ?

// ASCII character: copy as-is; non-ASCII (invalid UTF-8 here): replace with '?'

Replace with:
// ASCII character: copy as-is. Non-ASCII (invalid UTF-8 here), replace with '?'

@copilot : ASCII character: copy as-is. Non-ASCII (invalid UTF-8 here), replace with '?'

include/format_latin.h

src/main.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-11T16:06:41Z

@rzeldent I've opened a new pull request, #90, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ate display_flights function for clarity in latitude/longitude range formatting

rzeldent and others added 10 commits January 10, 2026 21:27

Merge branch 'main' into develop

ac4fa73

Update history section in README.md to reflect recent changes

7c90746

Merge branch 'develop' of https://github.com/rzeldent/esp32-flightrad…

0f63294

…ar24-ttgo into develop

Refactor display_flight function to simplify flag image handling

1fcfd3b

Fix flag image handling in display_flight function to prevent null po…

da98af2

…inter dereference

Merge branch 'main' into develop

17c6fd0

Add format_to_latin function for converting accented characters to ASCII

96e8fd9

Merge branch 'develop' of https://github.com/rzeldent/esp32-flightrad…

0951bc4

…ar24-ttgo into develop

Update format_to_latin function to enhance accented character handlin…

95b0eef

…g and adjust platformio.ini to set default environment

Copilot AI review requested due to automatic review settings January 11, 2026 15:23

Copilot started reviewing on behalf of rzeldent January 11, 2026 15:23 View session

Copilot AI reviewed Jan 11, 2026

View reviewed changes

rzeldent and others added 2 commits January 11, 2026 17:04

Update src/main.cpp

2e6428e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update include/format_latin.h

296c6c6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Jan 11, 2026

Fix malformed comment in format_latin.h #90

Draft

rzeldent and others added 3 commits January 11, 2026 17:06

Update include/format_latin.h

ffcba62

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/main.cpp

390008e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor format_to_latin function for improved UTF-8 handling and upd…

eeb2feb

…ate display_flights function for clarity in latitude/longitude range formatting

rzeldent merged commit 51e4a6f into main Jan 11, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop#89

Develop#89
rzeldent merged 15 commits intomainfrom
develop

rzeldent commented Jan 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

rzeldent Jan 11, 2026

Uh oh!

rzeldent Jan 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// ASCII character, copy as-is else // Invalid UTF-8, replace with ?
	// ASCII character: copy as-is; non-ASCII (invalid UTF-8 here): replace with '?'

Conversation

rzeldent commented Jan 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

rzeldent Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

rzeldent Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants