Skip to content

refactor: zaman to use the latest features#157

Open
soheilnikroo wants to merge 1 commit intomainfrom
refactor-zaman
Open

refactor: zaman to use the latest features#157
soheilnikroo wants to merge 1 commit intomainfrom
refactor-zaman

Conversation

@soheilnikroo
Copy link
Collaborator

No description provided.

@soheilnikroo soheilnikroo requested a review from Copilot October 11, 2025 14:01
@soheilnikroo soheilnikroo self-assigned this Oct 11, 2025
@soheilnikroo soheilnikroo added the enhancement New feature or request label Oct 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Zaman to use the latest features and modernizes the codebase with comprehensive improvements. The refactoring introduces a new modular architecture, improves type safety, adds extensive testing, and enhances the overall developer experience.

  • Modular Architecture: Restructured into packages with clear separation of concerns
  • CSS Variables & Theme System: Migrated from Emotion to CSS variables with a robust theming system
  • Enhanced i18n System: New internationalization provider with better locale management
  • Comprehensive Testing: Added extensive unit tests, E2E tests, and Storybook stories

Reviewed Changes

Copilot reviewed 259 out of 323 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/style/animation.ts Simplified animation exports to CSS class names
src/packages/time-picker/ Complete restructure with new types, components, and tests
src/packages/date-picker/ Modernized date picker with hooks and improved accessibility
src/packages/calendar-provider/ New context provider for calendar state management
src/packages/calendar/ Restructured calendar with sub-components and styling
src/i18n/ New internationalization system with provider and context
src/hooks/ Updated hooks with better error handling and TypeScript
src/docs/ Comprehensive documentation in MDX format
src/core/ New date and range engines for calendar logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +66 to +67
lastItemRef.style.transition = ''
lastItemRef.style.transform = ''
Copy link

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting style properties to empty string may not effectively reset CSS values. Consider using 'null' or 'unset' for more explicit style reset, or use removeProperty() method.

Copilot uses AI. Check for mistakes.
<input
ref={inputRef}
{...props?.inputAttributes}
{...props.inputAttributes}
Copy link

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed optional chaining on 'props.inputAttributes' which could lead to runtime errors if the prop is undefined. Consider adding the optional chaining back: '{...props.inputAttributes}' should be '{...props?.inputAttributes}'.

Suggested change
{...props.inputAttributes}
{...props?.inputAttributes}

Copilot uses AI. Check for mistakes.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@soheilnikroo soheilnikroo force-pushed the refactor-zaman branch 3 times, most recently from d84398d to 5939d6a Compare October 11, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant