Skip to content

Conversation

R-NK
Copy link

@R-NK R-NK commented May 5, 2021

Summary of the Pull Request

Currently, users have to modify the source to add apps or change the default setting.
This PR allows users to do that by creating a json file like below:

config.json

{
    "Apps": [
        {
            "ProcessName": "WindowsTerminal",
            "ExeFilePath": "wt.exe",
            "ModifierKeys": 1,
            "Keys": 84
        },
        {
            "ProcessName": "Spotify",
            "ExeFilePath": "Spotify.exe",
            "ModifierKeys": 1,
            "Keys": 83
        }
    ]
}

The json should be located at:

  1. same directory as WindowsTermialTray.exe
  2. $env:LOCALAPPDATA\WindowsTermialTray\config.json

Checklist

  • Implement Config class with builder pattern
  • Add a project for unit tests (I'm not familiar with C#, so I followed Microsoft's docs for unit test)
  • Change default key binding to T from oemtilde which only available on US Keyboard.

and just a trivial question, which is the correct application name, TermialTray or TerminalTray? Both of them are found at the source.

@R-NK R-NK changed the title Allow users to configuration settings by json Allow users to modify settings by json May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant