Add argument to ascent_source and avoid hygenie#69
Open
StarGazerM wants to merge 1 commit intos-arash:masterfrom
Open
Add argument to ascent_source and avoid hygenie#69StarGazerM wants to merge 1 commit intos-arash:masterfrom
StarGazerM wants to merge 1 commit intos-arash:masterfrom
Conversation
add test fix include macro call argument for arg more than 1
1f20398 to
8716b81
Compare
Owner
|
Thanks for the PR @StarGazerM! You could argue that it would be useful to try and make |
Author
|
The hygiene issue happens in macro expanded from original ascent_source! macro, if it contain any ungrounded identifier, for example: Although by itself, this source code is a valid ascent code, as long as variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ascent_source!include_source!syntax inside ascent.ascent_sourcebecause, binding need use$for macro variable binding in body ofascent_sourceExample :