Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

chore: bump sdk version, opt-out of ignoring deleted resources in pagination#205

Merged
sgbalogh merged 1 commit intomainfrom
release3
Jan 20, 2026
Merged

chore: bump sdk version, opt-out of ignoring deleted resources in pagination#205
sgbalogh merged 1 commit intomainfrom
release3

Conversation

@sgbalogh
Copy link
Member

No description provided.

@sgbalogh sgbalogh requested a review from a team as a code owner January 20, 2026 22:08
@greptile-apps
Copy link

greptile-apps bot commented Jan 20, 2026

Greptile Summary

Updated the SDK dependency from version 0.22.4 to 0.22.5 and modified pagination behavior for list-basins and list-streams commands to include resources pending deletion.

Key Changes:

  • SDK version bump to 0.22.5 enables access to the with_ignore_pending_deletions method
  • Changed list_all_basins and list_all_streams operations to explicitly set ignore_pending_deletions(false)
  • Only affects auto-paginated list operations (default behavior); manual pagination with --no-auto-paginate flag unchanged
  • Provides better visibility into resources in transitional states during deletion operations

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a straightforward dependency bump with a small, targeted behavioral change. The SDK version update is a minor patch version (0.22.4 → 0.22.5), and the only code changes explicitly opt out of the default behavior by setting ignore_pending_deletions(false). This makes the behavior more transparent by showing resources in deletion states rather than hiding them. The change is isolated to two list operations, doesn't affect critical paths, and maintains backward compatibility.
  • No files require special attention

Important Files Changed

Filename Overview
Cargo.lock Updated s2-sdk dependency from 0.22.4 to 0.22.5 with new checksum
Cargo.toml Bumped s2-sdk version requirement to 0.22.5
src/ops.rs Added with_ignore_pending_deletions(false) to list operations to show resources pending deletion during pagination

Sequence Diagram

sequenceDiagram
    participant CLI as CLI Command
    participant Ops as ops.rs
    participant SDK as s2-sdk (v0.22.5)
    participant API as S2 API

    alt list-basins (auto-paginate)
        CLI->>Ops: list_basins(no_auto_paginate=false)
        Ops->>Ops: Create ListAllBasinsInput
        Ops->>Ops: Set ignore_pending_deletions=false
        Ops->>SDK: list_all_basins(input)
        SDK->>API: Paginate through basins
        API-->>SDK: Include pending deletion resources
        SDK-->>Ops: Stream of BasinInfo
        Ops-->>CLI: Return basin stream
    end

    alt list-streams (auto-paginate)
        CLI->>Ops: list_streams(no_auto_paginate=false)
        Ops->>Ops: Create ListAllStreamsInput
        Ops->>Ops: Set ignore_pending_deletions=false
        Ops->>SDK: list_all_streams(input)
        SDK->>API: Paginate through streams
        API-->>SDK: Include pending deletion resources
        SDK-->>Ops: Stream of StreamInfo
        Ops-->>CLI: Return stream stream
    end
Loading

@sgbalogh sgbalogh merged commit cfa89fb into main Jan 20, 2026
7 checks passed
@sgbalogh sgbalogh deleted the release3 branch January 20, 2026 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant