refactor!: make idempotency_token private

[quettabit]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This breaking change makes the idempotency_token field private in both CreateBasinInput and CreateStreamInput, and removes the with_idempotency_token() builder methods. The token is now always auto-generated as a random UUID v4 inside the new() constructor, preventing users from setting or overriding it.

• The idempotency_token field visibility changes from pub to private in both CreateBasinInput and CreateStreamInput
• The with_idempotency_token() builder methods are removed from both structs
• Two integration tests that exercised idempotency with user-supplied tokens are removed (create_stream_idempotent_same_token and create_stream_idempotent_different_token_errors)
• The structs already have #[non_exhaustive] and Clone derives, so users must use new() (which auto-generates the token) and can clone() to reuse the same token for retries
• All remaining imports in tests/basin_ops.rs (including uuid and assert_matches) are still used by other tests

Confidence Score: 5/5

• This PR is safe to merge — it's a clean API surface reduction with no behavioral bugs.
• The change is straightforward: it hides a field and removes a builder method, enforcing that idempotency tokens are always auto-generated. The #[non_exhaustive] attribute already prevents direct struct construction, so users were already going through new(). The Clone derive ensures tokens can be reused for retries. No remaining references to the removed methods exist, and all test imports remain valid.
• No files require special attention.

Important Files Changed

Filename	Overview
src/types.rs	Makes idempotency_token field private in CreateBasinInput and CreateStreamInput, removes with_idempotency_token() builder methods; tokens are now always auto-generated via UUID in the new() constructors.
tests/basin_ops.rs	Removes two idempotency-related integration tests (create_stream_idempotent_same_token and create_stream_idempotent_different_token_errors) that relied on the now-removed with_idempotency_token method. All remaining imports are still used.

Flowchart

flowchart TD
    A["User calls CreateBasinInput::new() / CreateStreamInput::new()"] --> B["idempotency_token auto-generated via UUID v4"]
    B --> C["User chains .with_config() / .with_scope()"]
    C --> D["Input passed to S2::create_basin() / S2Basin::create_stream()"]
    D --> E["From impl extracts (Request, idempotency_token)"]
    E --> F["Token sent as S2_REQUEST_TOKEN header"]
    
    style B fill:#90EE90,stroke:#333
    
    G["Previously: User could call .with_idempotency_token()"] -.-> |"Removed"| B
    style G fill:#FFB6C1,stroke:#333

Loading

_{Last reviewed commit: fcb13e7}