Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2026

s2-protos Update

This PR updates the following submodules:

Remote Repository Submodule Path Change
s2-streamstore/s2-protos s2-protos fe043c4...1ea0452

This PR description was generated by sgoudham/update-git-submodules.

Changes

  • Updated s2-protos submodule
  • Regenerated proto TypeScript files
  • Regenerated OpenAPI TypeScript files

Commit: 1ea0452c9a333f9b746ff87f57a32d02087ca94b

@greptile-apps
Copy link

greptile-apps bot commented Jan 6, 2026

Greptile Summary

This PR updates the s2-protos submodule and regenerates TypeScript types, introducing critical breaking changes that will cause compilation failures.

Key Changes:

  • Updated s2-protos submodule from fe043c4 to 1ea0452
  • Regenerated OpenAPI-generated types from proto definitions
  • Renamed S2Format type to Format
  • Updated RevokeAccessTokenResponses from 200: unknown to 204: void
  • Removed s2-request-token header definitions from CreateOrReconfigureBasinData and CreateOrReconfigureStreamData types

Critical Issue:
The removal of s2-request-token header support from generated types breaks the handwritten SDK code in basins.ts and streams.ts, which still attempt to pass these headers when creating/updating basins and streams. This will cause TypeScript compilation errors. The proto change removing request token support needs to be reconciled with the SDK implementation.

Confidence Score: 0/5

  • This PR introduces critical breaking changes that will prevent the codebase from compiling, making it unsafe to merge without fixes.
  • The PR removes s2-request-token header support from generated types but the handwritten SDK code in basins.ts and streams.ts still attempts to pass these headers. This creates a type mismatch that will cause immediate TypeScript compilation failures. The proto changes appear legitimate, but they were not reconciled with the SDK implementation that depends on these headers.
  • packages/streamstore/src/generated/types.gen.ts - Critical: Removed header definitions break existing SDK code. Either the header support needs to be restored to the generated types, or the SDK implementation in basins.ts and streams.ts needs to be updated to remove references to these headers.

Important Files Changed

Filename Overview
packages/streamstore/src/generated/types.gen.ts Generated types file with critical breaking changes: removed s2-request-token headers from CreateOrReconfigureBasinData and CreateOrReconfigureStreamData types, renamed S2Format to Format, updated RevokeAccessTokenResponses from 200: unknown to 204: void. The removal of header definitions will cause TypeScript compilation errors in basins.ts and streams.ts that still attempt to pass these headers.
s2-protos Submodule update from commit fe043c4 to 1ea0452. Changes in proto definitions triggered regeneration of TypeScript types, including removal of request token header support and type renames. No issues with the submodule update itself.

Sequence Diagram

sequenceDiagram
    participant SDK as SDK (basins.ts)
    participant Types as Generated Types
    participant API as API

    Note over SDK,API: Creating Basin with Request Token
    SDK->>SDK: Prepare createBasin call
    SDK->>SDK: Add s2-request-token header
    SDK->>Types: createBasin(headers: {s2-request-token})
    Note over Types: ❌ ERROR: Type mismatch<br/>s2-request-token header<br/>no longer in type definition
    Types-->>SDK: TypeScript Compilation Error

    Note over SDK,API: Previous Working Flow (before PR)
    SDK->>Types: createBasin(headers: {s2-request-token})
    Types->>API: POST /basins/{basin}
    API-->>Types: Success Response
    Types-->>SDK: Return Response
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. packages/streamstore/src/generated/types.gen.ts, line 757-767 (link)

    syntax: Breaking change: s2-request-token header field has been removed from CreateOrReconfigureBasinData. This will cause TypeScript compilation errors in src/basins.ts:79 where the code attempts to pass headers: { "s2-request-token": requestToken }. Either the header needs to be restored to this type definition or the calling code needs to be updated to not use it.

  2. packages/streamstore/src/generated/types.gen.ts, line 1058-1068 (link)

    syntax: Breaking change: s2-request-token header field has been removed from CreateOrReconfigureStreamData. This will cause TypeScript compilation errors in src/streams.ts:86 where the code attempts to pass headers: { "s2-request-token": requestToken }. Either the header needs to be restored to this type definition or the calling code needs to be updated to not use it.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant