-
Notifications
You must be signed in to change notification settings - Fork 5
chore: update s2-protos to 1ea0452 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryThis PR updates the s2-protos submodule and regenerates TypeScript types, introducing critical breaking changes that will cause compilation failures. Key Changes:
Critical Issue: Confidence Score: 0/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant SDK as SDK (basins.ts)
participant Types as Generated Types
participant API as API
Note over SDK,API: Creating Basin with Request Token
SDK->>SDK: Prepare createBasin call
SDK->>SDK: Add s2-request-token header
SDK->>Types: createBasin(headers: {s2-request-token})
Note over Types: ❌ ERROR: Type mismatch<br/>s2-request-token header<br/>no longer in type definition
Types-->>SDK: TypeScript Compilation Error
Note over SDK,API: Previous Working Flow (before PR)
SDK->>Types: createBasin(headers: {s2-request-token})
Types->>API: POST /basins/{basin}
API-->>Types: Success Response
Types-->>SDK: Return Response
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
-
packages/streamstore/src/generated/types.gen.ts, line 757-767 (link)syntax: Breaking change:
s2-request-tokenheader field has been removed fromCreateOrReconfigureBasinData. This will cause TypeScript compilation errors insrc/basins.ts:79where the code attempts to passheaders: { "s2-request-token": requestToken }. Either the header needs to be restored to this type definition or the calling code needs to be updated to not use it. -
packages/streamstore/src/generated/types.gen.ts, line 1058-1068 (link)syntax: Breaking change:
s2-request-tokenheader field has been removed fromCreateOrReconfigureStreamData. This will cause TypeScript compilation errors insrc/streams.ts:86where the code attempts to passheaders: { "s2-request-token": requestToken }. Either the header needs to be restored to this type definition or the calling code needs to be updated to not use it.
2 files reviewed, 2 comments
s2-protos Update
This PR updates the following submodules:
This PR description was generated by sgoudham/update-git-submodules.
Changes
Commit: 1ea0452c9a333f9b746ff87f57a32d02087ca94b