fix(cli): only set default_stream_config when stream config args provided

[infiniteregrets]

closes #127

[greptile-apps]

Greptile Overview

Greptile Summary

This PR changes the CLI basin reconfiguration flow so default_stream_config is only sent when the user actually provides at least one stream-config option (storage class / retention policy / timestamping / delete-on-empty). This prevents unintentionally overwriting the basin’s default stream config when the user is only toggling other basin settings.

The change is localized to cli/src/ops.rs in reconfigure_basin, where the CLI builds an s2_sdk::types::BasinReconfiguration and then calls S2::reconfigure_basin with the assembled input.

Confidence Score: 4/5

• This PR is likely safe to merge with low behavioral risk.
• The change is small and localized, and it aligns behavior with user intent by avoiding unintended default stream config updates. Main remaining concern is maintainability: the guard condition can become incorrect if default_stream_config gains new fields, causing silent no-ops.
• cli/src/ops.rs

Important Files Changed

Filename	Overview
cli/src/ops.rs	Updates basin reconfiguration to only include default_stream_config when at least one stream-config field is explicitly set.

Sequence Diagram

sequenceDiagram
    participant CLI as cli (reconfigure_basin)
    participant SDK as s2_sdk::types::BasinReconfiguration
    participant S2 as s2_sdk::S2

    CLI->>SDK: BasinReconfiguration::new()
    alt any default_stream_config field set
        CLI->>SDK: with_default_stream_config(args.default_stream_config.into())
    end
    opt create_stream_on_append provided
        CLI->>SDK: with_create_stream_on_append(val)
    end
    opt create_stream_on_read provided
        CLI->>SDK: with_create_stream_on_read(val)
    end
    CLI->>S2: reconfigure_basin(ReconfigureBasinInput::new(basin, reconfig))
    S2-->>CLI: BasinConfig
    CLI-->>CLI: convert into cli::types::BasinConfig

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}