fix(cli): skip extra newline for command records in tail text output

[infiniteregrets]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR updates the CLI tail text output path to avoid writing an extra newline after printing a record when the record is a “command record” (and text mode is selected).

The change aligns tail with existing read behavior by conditionally skipping writer.write_all(b"\n") when args.format == RecordFormat::Text && record.is_command_record(). This interacts with write_record() in cli/src/main.rs:596+, where command records in text mode are printed to stderr (eprintln!) rather than written to the configured output writer (stdout/file).

Confidence Score: 3/5

• This PR is close to safe to merge, but has an output-format regression for text mode when command records occur in the stream.
• The change is small and localized, but it alters record boundary handling: command records in text mode emit to stderr and now also emit no separator on the output writer, which can concatenate stdout output across records.
• cli/src/main.rs (tail/read text formatting logic)

Important Files Changed

Filename	Overview
cli/src/main.rs	Skips writing an extra newline after tail/read records in text mode for command records; introduces an output-boundary issue because command records write to stderr and no longer emit a separator newline on the output writer.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant CLI as s2 cli
    participant OPS as ops::tail/ops::read
    participant WR as output writer (stdout/file)
    participant ERR as stderr

    U->>CLI: s2 tail/read --format text
    CLI->>OPS: request stream of SequencedRecord
    loop for each record
        OPS-->>CLI: SequencedRecord
        alt record is command_record
            CLI->>ERR: eprintln!(command summary)
            note over CLI,WR: PR skips writing "\n" to WR for command records
        else record is data
            CLI->>WR: TextFormatter::write_record(record)
            CLI->>WR: write_all("\n")
        end
        CLI->>WR: flush()
    end

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}