feat(common): add EnumString and IntoStaticStr derives to BasinScope

[shikhar]

Summary

• Add strum::EnumString and strum::IntoStaticStr derives to BasinScope enum, enabling string parsing and static str conversion.

Test plan

• just test passes

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR adds strum::EnumString and strum::IntoStaticStr derives to the BasinScope enum in common/src/types/basin.rs, enabling string-to-enum parsing via FromStr (e.g. "aws:us-east-1".parse::<BasinScope>()) and enum-to-&'static str conversion.

• The strum crate with features = ["derive"] is already a workspace dependency, so no new dependencies are introduced.
• The existing #[strum(serialize = "aws:us-east-1")] attribute already drives the new derives correctly — all three (Display, EnumString, IntoStaticStr) will use the same canonical string "aws:us-east-1", ensuring consistency.
• No existing FromStr implementation exists for BasinScope, so there is no conflict from EnumString.
• The change is minimal and self-contained.

Confidence Score: 5/5

• Safe to merge — purely additive derive macros with no breaking changes.
• The change is three lines, purely additive (new trait impls via derives), consistent with the existing strum usage on the same enum, and relies on a dependency already in the workspace. No conflicts, no logic changes, no risk surface.
• No files require special attention.

Important Files Changed

Filename	Overview
common/src/types/basin.rs	Adds strum::EnumString and strum::IntoStaticStr derives to BasinScope; no conflicts with existing impls, strum dependency already present with derive feature, and the #[strum(serialize = "aws:us-east-1")] attribute already in place correctly drives all three derives.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["str input: aws:us-east-1"]
    B["BasinScope::AwsUsEast1"]
    C["String via Display"]
    D["static str via IntoStaticStr"]

    A -->|"EnumString / FromStr - NEW"| B
    B -->|"Display existing"| C
    B -->|"IntoStaticStr - NEW"| D

Loading

_{Reviews (1): Last reviewed commit: "feat(common): add EnumString and IntoSta..." | Re-trigger Greptile}