Skip to content

chore: update basin endpoint from b.aws.s2.dev to b.s2.dev#346

Merged
shikhar merged 1 commit intomainfrom
shikhar/update-basin-endpoint
Mar 22, 2026
Merged

chore: update basin endpoint from b.aws.s2.dev to b.s2.dev#346
shikhar merged 1 commit intomainfrom
shikhar/update-basin-endpoint

Conversation

@shikhar
Copy link
Copy Markdown
Member

@shikhar shikhar commented Mar 22, 2026

Summary

  • Update basin endpoint from b.aws.s2.dev to b.s2.dev in both lite handler paths and SDK default endpoints.

Test plan

  • Verify basin connections work with the new endpoint

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@shikhar shikhar changed the title fix: update basin endpoint from b.aws.s2.dev to b.s2.dev chore: update basin endpoint from b.aws.s2.dev to b.s2.dev Mar 22, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 22, 2026

Greptile Summary

This PR updates the S2 basin endpoint domain from b.aws.s2.dev to b.s2.dev in two places: the lite handler path constants and the SDK's default for_aws() endpoint configuration. The change is minimal, consistent, and no stale references to the old domain remain in the codebase.

  • lite/src/handlers/v1/paths.rs: cloud_endpoints::BASIN updated from https://{basin}.b.aws.s2.dev/v1 to https://{basin}.b.s2.dev/v1
  • sdk/src/types.rs: basin_authority in S2Endpoints::for_aws() updated from b.aws.s2.dev to b.s2.dev
  • The account endpoint (aws.s2.dev) is intentionally left unchanged in both files, consistent with the PR scope

Confidence Score: 5/5

  • Safe to merge — minimal, targeted endpoint string update with no logic changes and no remaining stale references.
  • Both changed lines are simple string literal replacements. A grep confirms no remaining occurrences of b.aws.s2.dev anywhere in the repository. The account endpoint is deliberately unchanged, and the PR scope is exactly as described.
  • No files require special attention.

Important Files Changed

Filename Overview
lite/src/handlers/v1/paths.rs Updates the BASIN cloud endpoint constant from b.aws.s2.dev to b.s2.dev; ACCOUNT endpoint (aws.s2.dev) intentionally unchanged.
sdk/src/types.rs Updates basin_authority in S2Endpoints::for_aws() from b.aws.s2.dev to b.s2.dev; account authority (aws.s2.dev) intentionally unchanged.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Client["Client Request"]
    Client --> AccountOp["Account Operation"]
    Client --> BasinOp["Basin Operation"]

    AccountOp --> AccountEndpoint["aws.s2.dev/v1\n(unchanged)"]
    BasinOp --> BasinEndpoint["{basin}.b.s2.dev/v1\n(updated from b.aws.s2.dev)"]

    subgraph lite["lite/src/handlers/v1/paths.rs"]
        AccountEndpoint
        BasinEndpoint
    end

    subgraph sdk["sdk/src/types.rs — S2Endpoints::for_aws()"]
        AccountAuth["account_authority: aws.s2.dev\n(unchanged)"]
        BasinAuth["basin_authority: b.s2.dev\n(updated)"]
    end
Loading

Reviews (1): Last reviewed commit: "fix: update basin endpoint from b.aws.s2..." | Re-trigger Greptile

@shikhar shikhar merged commit f9b73cd into main Mar 22, 2026
18 checks passed
@shikhar shikhar deleted the shikhar/update-basin-endpoint branch March 22, 2026 15:34
@s2-release-plz s2-release-plz bot mentioned this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant