Skip to content

chore: remove unused RecordBatch and RecordBatcher - #589

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-recordbatch-and-recordbatcher-1de392
Closed

chore: remove unused RecordBatch and RecordBatcher#589
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-recordbatch-and-recordbatcher-1de392

Conversation

@detail-app

@detail-app detail-app Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Removes storage/src/record/batcher.rs and its re-export from
storage/src/record/mod.rs.

RecordBatch and RecordBatcher had no production callers anywhere in
the codebase. They were re-exported from s2-storage but never imported
or used by s2-lite (the only dependent crate) or any other crate. Their
only consumers were the #[cfg(test)] module within batcher.rs itself.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from infiniteregrets June 23, 2026 16:07
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@shikhar shikhar closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant