Skip to content

chore: remove unused DeepSize trait and all implementations - #593

Closed
detail-app[bot] wants to merge 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-deepsize-trait-and-all-impleme-00eee5
Closed

chore: remove unused DeepSize trait and all implementations#593
detail-app[bot] wants to merge 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-deepsize-trait-and-all-impleme-00eee5

Conversation

@detail-app

@detail-app detail-app Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Removes the DeepSize trait (defined in common/src/deep_size.rs) and all impl DeepSize blocks across s2-common and s2-storage. The trait computed recursive byte-sizes of record types.

The sole production call-site was envelope.headers().deep_size() inside MeteredSize for Record, which was replaced in #349 with a cached HeaderSizing approach. Since then, the entire DeepSize call graph has had no production entry point — every impl DeepSize block only delegates to other impl DeepSize blocks that are themselves never invoked from outside.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from infiniteregrets June 24, 2026 16:37
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@infiniteregrets

Copy link
Copy Markdown
Member

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant