changing ADC threshold for time calib

[bseidlit]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

PR Summary: ADC Threshold Adjustment for Time Calibration QA

Motivation

This change updates the calorimeter QA analysis (CaloValid) to use distinct ADC thresholds for different detector subsystems during time calibration studies. Previously, raw tower energy thresholds were applied uniformly across all calorimeter systems. This modification enables more precise QA by using detector-specific thresholds optimized for timing analysis.

Key Changes

• Replaced unified threshold with detector-specific thresholds:

  • adc_threshold_emcal = 70 (for CEMC/EMCal)
  • adc_threshold_hcal = 30 (for HCALIN and HCALOUT)

• Updated raw tower processing filters in the event loop:

  • CEMC (TOWERS_CEMC): Now uses adc_threshold_emcal for raw time histogram and fraction-above-threshold calculations
  • HCALOUT (TOWERS_HCALOUT): Now uses adc_threshold_hcal for raw time histogram and fraction-above-threshold calculations
  • HCALIN (TOWERS_HCALIN): Now uses adc_threshold_hcal for raw time histogram and fraction-above-threshold calculations

• Applied to both collision systems: AuAu and non-AuAu data processing paths

Potential Risk Areas

• QA histogram interpretation: Any downstream analysis relying on calorimeter timing distributions (h_etaphi_time_raw, h_etaphi_fracHitADC) will reflect the new threshold values. Comparisons with historical QA results may show differences.
• Reconstruction behavior: No changes to actual reconstruction algorithms, only to QA filtering and histogram filling.
• Performance: Negligible impact; this is a simple threshold adjustment in the QA module.

Notes

• AI disclaimer: This summary was generated from code analysis. Verify against PR discussions for complete context on physics motivations.
• No changes to public APIs or exported entities
• Modification is localized to QA analysis code only

Possible Future Improvements

• Consider if these threshold values should be configurable parameters rather than hardcoded
• Document the physics rationale for the specific values (70 for EMCal, 30 for HCal) in code comments
• Consider energy-dependent thresholds if per-tower calibration quality varies significantly

[coderabbitai]

📝 Walkthrough

Walkthrough

The calorimeter validation code introduces detector-specific ADC thresholds, separating HCAL and EMCal threshold variables (30 and 70 respectively) to replace a single threshold previously applied uniformly across all calorimeter subsystems.

Changes

Cohort / File(s)	Change Summary
Detector-specific ADC thresholds offline/QA/Calorimeters/CaloValid.cc	Replaces single adc_threshold with adc_threshold_hcal (30) and adc_threshold_emcal (70); updates conditional energy checks for CEMC, HCALIN, and HCALOUT towers to use appropriate per-subsystem thresholds

✨ Finishing touches

• 📝 Docstrings were successfully generated.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #4126

[sphenix-jenkins-ci]

Build & test report

Report for commit 57a9dd2851c2a1e8a786d54258851b94feb2a060:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = 9.8006e-12 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = 0.00727412 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = 0.00169328 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = 5.51613 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration