More change. by Ishangoel11 · Pull Request #4163 · sPHENIX-Collaboration/coresoftware

Ishangoel11 · 2026-02-04T20:34:32Z

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

TPC Dead/Hot Channel Masking Support

Motivation / context
This PR adds the ability to mask known dead and hot TPC channels during clustering, allowing the reconstructor to ignore problematic pads from CDB-sourced or file-sourced channel maps. This helps produce more robust cluster reconstruction for both experimental and simulated data where specific channels should be excluded.

Key changes

New mask container type: typedef std::map<TrkrDefs::hitsetkey, std::unordered_setTrkrDefs::hitkey> hitMaskTpcSet.
Public setters to enable mask behavior and specify sources:
- SetMaskChannelsFromFile()
- SetDeadChannelMapName(const std::string&)
- SetHotChannelMapName(const std::string&)
New helper: TpcClusterizer::makeChannelMask(hitMaskTpcSet& aMask, const std::string& dbName, const std::string& totalChannelsToMask) to populate masks from CDB or files.
Thread-local propagation: thread_data extended with pointers and flags:
- hitMaskTpcSet *deadMap = nullptr; *hotMap = nullptr; bool maskDead = false; bool maskHot = false
  These are set from the main object (m_deadChannelMap/m_hotChannelMap, m_maskDeadChannels/m_maskHotChannels) and passed into worker threads.
Mask-aware clustering logic: introduces an is_pad_masked lambda and applies mask checks at multiple hot spots (edge detection and the hit-processing loops) to skip masked pads before cluster/edge decisions.
New includes and containers: added CDBTTree.h, CDBInterface.h, memory, unordered_set and related header changes.
Change size: ~+186/-14 in implementation, +34/-4 in header (estimated).

Potential risk areas

Thread-safety: masks are shared (read-only) pointers used by multiple worker threads. Ensure access patterns remain read-only and that the mask containers are fully initialized before threads read them.
Reconstruction behavior: masking changes which pads contribute to edges and clusters—this will alter outputs and may affect downstream analyses and QA comparisons.
IO/format dependency: mask loading expects specific CDB/file schema (layer/sector/side/pad and TotalDeadChannels/TotalHotChannels metadata). Mismatches or missing CDB entries can cause masking to be silently skipped or produce incomplete masks.
Performance: additional per-pad checks in tight loops add branching and lookups that may impact throughput; effect should be measured on representative datasets.
Error handling: current behavior logs errors and may continue without masks; clearer fallbacks or hard-fail options might be needed for some workflows.

Possible future improvements

Cache mask results across runs to avoid repeated CDB/file lookups.
Add stricter validation and clearer error reporting for mask file/CDB schema mismatches.
Benchmark and optimize mask lookup (e.g., more compact containers or precomputed bitsets) to reduce per-hit overhead.
Add unit/integration tests and QA plots showing reconstruction differences with/without masking.
Document the expected CDB/file schema and example files for users.

Note on analysis

This summary was generated with AI assistance; please verify critical details (function signatures, threading initialization order, and exact I/O expectations) against the code before merging—AI may make mistakes.

…llowing people to use dead/hot maps both in simulation and data.

coderabbitai · 2026-02-04T20:41:21Z

📝 Walkthrough

Walkthrough

Adds dead/hot TPC channel masking to TpcClusterizer: new mask container type, setters to enable masks and name maps, makeChannelMask helper to build masks (CDB/file), per-thread mask pointers/flags, and mask checks integrated into pad/hit processing and clustering logic to skip masked channels.

Changes

Cohort / File(s)	Summary
Header: API & types `offline/packages/tpc/TpcClusterizer.h`	Adds `hitMaskTpcSet` typedef, public setters `SetMaskChannelsFromFile()`, `SetDeadChannelMapName()`, `SetHotChannelMapName()`, and private `makeChannelMask()` declaration. Adds private members: `m_deadChannelMap`, `m_hotChannelMap`, `m_maskDeadChannels`, `m_maskHotChannels`, `m_maskFromFile`, `m_deadChannelMapName`, `m_hotChannelMapName`.
Implementation: masking logic `offline/packages/tpc/TpcClusterizer.cc`	Implements `makeChannelMask()` (CDB/file support), adds includes (`CDBTTree.h`, `CDBInterface.h`, memory utilities), extends `thread_data` with `deadMap`, `hotMap`, `maskDead`, `maskHot`, wires mask maps into `InitRun` and per-thread initialization, and injects `is_pad_masked` checks across hit/cluster processing to skip masked pads. Adjusts control flow to honor masking flags.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sphenix-jenkins-ci · 2026-02-05T07:15:14Z

Build & test report

Report for commit 2110245677195fc344372268bc0b40f8947fb239:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.7331 / 72, and combined p-Value = 0.99837
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

sphenix-jenkins-ci · 2026-02-05T10:54:01Z

Build & test report

Report for commit 40660d1532e54f5c5aab4a2f86d8510823a25b23:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.7331 / 72, and combined p-Value = 0.99837
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

sphenix-jenkins-ci · 2026-02-06T00:39:19Z

Build & test report

Report for commit a0c4f0024bf1d9fc1f5e4874d3f99283fe073c03:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.7331 / 72, and combined p-Value = 0.99837
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Ishan Goel and others added 8 commits February 2, 2026 13:46

To include the dead/hot counters inside the edge counter as well as a…

0b26d18

…llowing people to use dead/hot maps both in simulation and data.

Some additional fix

80ba49a

New changes

505d785

Some more

1a6a8c0

Another change

86043f3

New

85003e4

More change.

40660d1

Good

2110245

Final Change (Hopefully)

a0c4f00

osbornjd merged commit dde76a8 into sPHENIX-Collaboration:master Feb 6, 2026
22 checks passed

coderabbitai bot mentioned this pull request Feb 12, 2026

Fixes for maps. #4175

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More change.#4163

More change.#4163
osbornjd merged 9 commits intosPHENIX-Collaboration:masterfrom
Ishangoel11:master

Ishangoel11 commented Feb 4, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

sphenix-jenkins-ci bot commented Feb 5, 2026

Uh oh!

sphenix-jenkins-ci bot commented Feb 5, 2026

Uh oh!

sphenix-jenkins-ci bot commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Ishangoel11 commented Feb 4, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

TPC Dead/Hot Channel Masking Support

Uh oh!

coderabbitai bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

sphenix-jenkins-ci bot commented Feb 5, 2026

Build & test report

Uh oh!

sphenix-jenkins-ci bot commented Feb 5, 2026

Build & test report

Uh oh!

sphenix-jenkins-ci bot commented Feb 6, 2026

Build & test report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ishangoel11 commented Feb 4, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2026 •

edited

Loading