Skip to content

feat: add setter for cluster map name#4164

Merged
osbornjd merged 1 commit intosPHENIX-Collaboration:masterfrom
osbornjd:clustermapname
Feb 5, 2026
Merged

feat: add setter for cluster map name#4164
osbornjd merged 1 commit intosPHENIX-Collaboration:masterfrom
osbornjd:clustermapname

Conversation

@osbornjd
Copy link
Copy Markdown
Contributor

@osbornjd osbornjd commented Feb 5, 2026

Adds a cluster map name setter so that only the seed DST can be read in

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Summary

Motivation / Context
This PR adds configurability for the cluster container lookup in TrackSeedTrackMapConverter, enabling flexible selection of cluster data sources during track seed to track map conversion. Previously, the cluster container was hardcoded to "TRKR_CLUSTER", limiting users' ability to process alternative cluster containers (e.g., different seed DST inputs).

Key Changes

  • Added public setter method setClusterMapName(const std::string& name) to TrackSeedTrackMapConverter class
  • Introduced private member variable m_clusterMapName with default value "TRKR_CLUSTER" to maintain backward compatibility
  • Updated getNodes() method to use m_clusterMapName for cluster container lookup instead of hardcoded string
  • Improved error message to report the requested cluster container name, aiding debugging

Potential Risk Areas

  • Reconstruction behavior: Users must ensure the specified cluster container exists in the DST, or the conversion will abort with an event error; silent failures are prevented by explicit error handling
  • Backward compatibility: Default behavior is preserved ("TRKR_CLUSTER"), so existing configurations unaffected
  • Configuration dependency: New configuration option adds an implicit dependency on correct DST structure that callers must manage

Possible Future Improvements

  • Consider allowing multiple cluster containers or a list of fallback options if one is unavailable
  • Add documentation/examples of supported cluster container names in coresoftware wiki
  • Consider similar configurability for other hardcoded container names if patterns emerge

Note on AI-generated analysis: This summary is based on AI analysis of code changes. Readers should verify details against actual PR code and consult with the author regarding specific use cases and DST structure requirements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

TrackSeedTrackMapConverter now uses a configurable cluster map name instead of a hard-coded "TRKR_CLUSTER" string. A private member variable with default value is introduced, along with a public setter method to allow external configuration of the cluster container lookup key.

Changes

Cohort / File(s) Summary
TrackSeedTrackMapConverter Implementation
offline/packages/TrackingDiagnostics/TrackSeedTrackMapConverter.h, TrackSeedTrackMapConverter.cc
Introduced configurable cluster map name via new private member m_clusterMapName (default: "TRKR_CLUSTER") and public setter setClusterMapName(). Replaced hard-coded cluster container lookup key with the configurable member; updated error messages to reflect actual container names being requested.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sphenix-jenkins-ci
Copy link
Copy Markdown

Build & test report

Report for commit 83a66dbe76cb5dcb3eaccbe002fac9f171bd2321:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@osbornjd osbornjd merged commit 921c470 into sPHENIX-Collaboration:master Feb 5, 2026
22 checks passed
@osbornjd osbornjd deleted the clustermapname branch February 5, 2026 13:24
@coderabbitai coderabbitai bot mentioned this pull request Feb 27, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant