Closed
Conversation
to be able to turn those methods on/off in the DataBlock interface without causing compile errors in the implementations.
revert to holding serialized and actual data. otherwise we can't be compatible with existing N5 datasets.
* Move ReadData etc to separate classes * Add ReadData.writeTo(OutputStream) * Add EncodedReadData that wraps a ReadData and an OutputStreamEncoder * Compression (BytesCodec) can encode ReadData. (This might happen immediately or later when the ReadData is written to OutputStream).
We still need a custom interface "OutputStreamOperator" because we want to throw IOException and UnaryOperator::apply doesn't.
When data is requested from the LazyReadData, the LazyReadData will ask its OutputStreamWriter to write the data to a ByteArrayOutputStream. When the LazyReadData itself is written to an OutputStream, it will pass that OutputStream to its OutputStreamWriter (without loading the data into a byte[] array first).
avoids the Compression argument to encode/decode methods
This is in preparation for moving SplittableReadData into a separate PR
tpietzsch
force-pushed
the
splittable
branch
from
ca9b653 to
a3fa06a
Compare
Contributor
|
@tpietzsch I think everything in this PR has been merged elsewhere into master already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything related to splitting
ReadDatamoved here from #137also see relevant discussion there
@bogovicj Feel free to start prototyping
limit(...),slice(...),split(...)here...