Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR represents a significant architectural refactoring of the plugin integration system for Quartz Syncer. The main change introduces a unified PluginIntegration interface that all plugin compilers now implement, replacing the previous ad-hoc compiler classes. This enables:
- Automatic style management through a new
AssetSyncersystem - Better separation of concerns with pattern-based compilation
- Support for Excalidraw drawings with light/dark theme variants
- Enhanced styles for Fantasy Statblocks and Datacore integrations
Key Changes:
- Introduced unified
PluginIntegrationinterface with pattern-based compilation - Added
AssetSyncerto automatically manage integration styles in the Quartz repository - Implemented Excalidraw support using the ExcalidrawAutomate API
- Added new setting
manageSyncerStylesto control automatic style injection
Reviewed changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| versions.json | Added version mapping for 1.9.2 |
| package.json, manifest.json, package-lock.json | Version bump to 1.9.2 |
| main.ts | Added default value for manageSyncerStyles setting |
| src/models/settings.ts | Added manageSyncerStyles setting field |
| src/views/SettingsView/Views/IntegrationSettings.ts | Refactored to use integration registry instead of hard-coded integrations |
| src/compiler/integrations/types.ts | New file defining PluginIntegration interface and related types |
| src/compiler/integrations/registry.ts | New integration registry for managing plugin integrations |
| src/compiler/integrations/index.ts | Central export point for integrations module |
| src/compiler/integrations/dataview.ts | Dataview integration using new interface |
| src/compiler/integrations/datacore.ts | Datacore integration with complete SCSS styles |
| src/compiler/integrations/excalidraw.ts | New Excalidraw integration implementation |
| src/compiler/integrations/fantasy-statblocks.ts | Fantasy Statblocks integration with updated styles |
| src/compiler/integrations/auto-card-link.ts | Auto Card Link integration refactored |
| src/compiler/integrations/AssetSyncer.ts | New asset syncer for managing integration styles |
| src/compiler/PluginCompiler.ts | Refactored to use integration registry and pattern compilation |
| src/repositoryConnection/RepositoryConnection.ts | Added getRawFile, updateFiles signature changes, raw file staging |
| src/publisher/Publisher.ts | Integrated AssetSyncer into publish flow |
| src/utils/styles.ts | Removed (styles moved to integration files) |
| src/compiler/plugins/*.ts | Removed old compiler files |
| scripts/generateSyncerSettings.mjs | Added manageSyncerStyles default |
| docs/* | Updated Excalidraw documentation and changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.excalidraw.md) are automatically converted to embedded SVG images.![[Example.excalidraw]]) are supported.PluginIntegrationinterface.quartz/styles/syncer/.quartz/styles/syncer/with automaticcustom.scssimport management.@use "./base.scss"to ensure proper style ordering.