Closed
Conversation
* refactor: remove broker * refactor: update benchmarks * docs: correct spelling test: deploy contracts in fork tests * test: polishes * test: small changes * test: increase coverage --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
* build: install evm-utils refactor: remove Adminable logic from this repo refactor: remove Batch logic from this repo refactor: remove NoDelegateCall logic from this repo refactor: use BaseScript from evm-utils build: update evm utils test: use evm utils common tests test: remove mocks refactor: remove no longer needed errors * address shub's feedback * build: update commit test: declare the date in Defaults * test: use UTC for feb 1 constant
…ablier-labs#1173) * feat: return refunded amounts in cancel functions * feat: make cancelMultiple non-reverting * docs: polish natspec --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
* test(refactor): StreamIDs struct in Types * test: use shorter name for the stream ids --------- Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com>
* docs: rename VestingMath to StreamingMath * refactor: rename functions to use short form * docs: replace Longer form with Shorter form
* test: refactor fork tests * test: fix bug * test(fork): declare initialHolderBalance as uint128 test(fork): rename fuzzed param to create instead of lockup test(defaults): remove unneeded function test(assertions): add compare function for LockupLinear.UnlockAmounts * move resetPrank above approve contract --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
* feat: implement aggregate balance logic build: lower the optimizer runs test: include aggregate balance assertions * test(chore): correct inv string mess * some nitpicks --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
* build: bump evm-utils refactor: update tests and scripts accordingly * chore: move evm-utils under dependencies * fix remappings path * test(defaults): declare 6D cliff amount based on the 18D one chore: set rules off in solhint.json * refactor: remove unneeded params from scripts
build: use public rpc
* docs: refactor SECURITY doc * docs: smol polish --------- Co-authored-by: Paul Razvan Berg <prberg@proton.me>
* docs: improve writing in NatSpec refactor: use more named params test: fix typos in comments, and improve writing test: new invariant for deposited amounts sum >= aggregate balance * docs: improve writing in NatSpec test: more specific descriptors * docs: polish comments * test(invariant): remove redundant invariant --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
* chore: remove unused custom error docs: add assumption about double entry-point tokens * build: bump evm utils build: lower optimizer runs to 50 feat: add native token logic refactor: move modifier logic into private function refactor: don't allow creation with native token docs: improve assumption about double entry point token test: update tests accordingly * docs: add NatSpec for the token * chore: rename custom error docs: add more explanation for nativeToken * typo * build: 500 optimizer runs * docs: polish comments
chore: add "test:bulloak" command chore: add vscode formatter for json,md,svg,yaml chore: remove file association
test(refactor): use setMsgSender
…s#1228) * refactor: rename mapping to aggregateAmount chore: add --nmt "testFork" in test lite * chore: update comments * test: polish invariants * refactor: rename to "LockupMath" --------- Co-authored-by: Paul Razvan Berg <prberg@proton.me>
chore: remove fs permissions from scripts
refactor: add solidity dir under scripts
chore: recommend VSCode extensions
ci: new cache mechanism
chore: prettier ignore husky chore: enable prose wrap only for Markdown files
* feat: access based control over collect fee function * docs: polish comment * refactor: prefix events with parent contract * style: imports order rule in solhint * build: bump evm-utils * build: bumpo evm-utils docs: fix inherited components perf: use internal function to check role Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com> --------- Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com>
refactor: remove contract size check fron allowToHook test: remove unneeded defaults style: empty line between imports docs: polish security assumption
* perf: refactor for code size optimization * refactor: remove Recover, AllowToHook and SetNFTDescriptor events perf: index streamId in events * revet: emit AllowToHook and SetNFTDescriptor events perf: index event parameters * fix typo * revert: move code from LockupMath to SablierLockup perf: assign struct directly into the storage * perf: forward variables without struct inside internal functions * refactor: use sender address to check stream existence --------- Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com>
* feat: add SablierLockupState contract refactor: move all SablierLockupBase logic into SablierLockup refactor: update error names accordingly test: update import paths accordingly chore: reclassifying function headers refactor: use native type for the constructor param include token to sender check * internal header in batch contract * refactor(test): rename lockup-base directory to lockup-state fix: inherited components chore: order events and functions alphabetically --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
* build: bump openzeppelin, evm-utils and forge-std test: separate constants from defaults contract test: use random address, rewind and skip from forge-std test: fix expected error if token address is not contract chore: rename bun scripts * chore: just use solhint
refactor: functions classification in Sablier Lockup
chore: just scripts
* refactor: use comptroller * perf: polish transferFeesToComptroller docs: add natspec comments about comptroller test: transferFeesToComptroller * docs: polishes test: admin to comptroller handler * build: bump evm-utils commit test: uncomment batch test * build: bump evm-utils test: update tests accordingly * docs: improve transferFeesToComptroller natspec * perf: uses ISablierComptroller in events perf: removes feePaid variable from _withdraw docs: polishes comments test: sets comptroller as caller in modifier chore: adds optional args in justfile * script: fix just command * chore: uses ETH_FROM in .env.example * docs: polish comment * revert: feePaid variable * build: bump evm-utils refactor: remove transfer fees function * chore: remove unused code --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
Member
|
Reopening it. Refer to sablier-labs/gha-utils#43 for implementation in Thanks for the PR @itsshantanu, it would have been a good idea to mention sablier-labs/gha-utils#43 in the PR description since both depends on each other. |
Author
|
Thanks for the feedback! You're absolutely right — I should have mentioned that in the PR description. I’ll make sure to include such cross-references in future PRs to improve clarity and context. |
Member
|
Hi @itsshantanu, I'm closing this PR as it now contains numerous conflicts. Could you please submit a new PR once the new features are implemented? We will then test the CI for all tests. Also, thank you so much for your efforts on this PR, excellent work! I'm excited about using BuildBear CIs soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow file to automate linting, building, and testing for the repository. The workflow is designed to streamline CI processes and ensure code quality for changes pushed to the
mainbranch or submitted via pull requests.Continuous Integration Setup:
.github/workflows/bb-ci-utils.yml: Added a new workflow named "BB-CI: Build and Test" that triggers onpush,pull_request, andworkflow_dispatchevents. It includes three jobs:lint: Runs the Forge linting workflow fromsablier-labs/gha-utils.build: Executes the Forge build workflow fromsablier-labs/gha-utils.test-utils: Runs the Forge test workflow with atest-optimizedprofile and focuses ontests/utils/**/*.solfiles. This job depends on the completion oflintandbuild.