Skip to content

chore: deprecate sophon#1463

Merged
smol-ninja merged 1 commit intostagingfrom
chore/depracate-sophon
Mar 17, 2026
Merged

chore: deprecate sophon#1463
smol-ninja merged 1 commit intostagingfrom
chore/depracate-sophon

Conversation

@andreivladbrg
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd393fdb-50a6-434e-97bf-4926fc0c2532

📥 Commits

Reviewing files that changed from the base of the PR and between 93abe68 and 244bd8d.

📒 Files selected for processing (4)
  • flow/scripts/solidity/FlowNFTDescriptorAddresses.sol
  • foundry.base.toml
  • lockup/scripts/solidity/LockupNFTDescriptorAddresses.sol
  • utils/src/tests/ChainId.sol
💤 Files with no reviewable changes (3)
  • lockup/scripts/solidity/LockupNFTDescriptorAddresses.sol
  • foundry.base.toml
  • flow/scripts/solidity/FlowNFTDescriptorAddresses.sol

Walkthrough

The changes remove SOPHON chain support across multiple configuration and smart contract files. Specifically, the SOPHON chain ID case is deleted from NFT descriptor address logic in both Flow and Lockup modules, the SOPHON RPC endpoint is removed from the foundry configuration, and the ChainId test utility is updated to remove the SOPHON constant and reduce the mainnet count from 24 to 23. The getAllMainnets() and getName() functions are correspondingly updated to exclude SOPHON from their logic.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, making it impossible to evaluate whether it relates to the changeset. Add a description explaining why SOPHON is being deprecated and the impact of removing it from the codebase.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: deprecate sophon' accurately describes the primary change of removing SOPHON support across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/depracate-sophon
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting to generate walkthrough in a markdown collapsible section.

@smol-ninja smol-ninja merged commit 5ec262e into staging Mar 17, 2026
41 of 42 checks passed
@smol-ninja smol-ninja deleted the chore/depracate-sophon branch March 17, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants