Skip to content

chore: add denergy previous nft descriptors#1478

Merged
andreivladbrg merged 1 commit intomainfrom
chain/denergy
Mar 23, 2026
Merged

chore: add denergy previous nft descriptors#1478
andreivladbrg merged 1 commit intomainfrom
chain/denergy

Conversation

@smol-ninja
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddf09016-b067-4b63-a457-7c41a7360aff

📥 Commits

Reviewing files that changed from the base of the PR and between 2ebd537 and 5ba9ef8.

📒 Files selected for processing (2)
  • flow/scripts/solidity/FlowNFTDescriptorAddresses.sol
  • lockup/scripts/solidity/LockupNFTDescriptorAddresses.sol

Walkthrough

The pull request extends two NFT descriptor address resolver contracts to support the DENERGY chain. The changes add conditional branches in the nftDescriptorAddress() function of both FlowNFTDescriptorAddresses.sol and LockupNFTDescriptorAddresses.sol that map block.chainid equal to ChainId.DENERGY to their respective NFT descriptor contract addresses. No function signatures were modified, and all existing chain-id mappings remain intact.

Possibly related PRs

  • evm-monorepo#1464: Adds broader DENERGY chain support by introducing ChainId.DENERGY constant and additional chain-specific address mappings in utility contracts and chain configuration files.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a pull request description explaining the purpose and context of adding DENERGY chain support to the NFT descriptor addresses.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding DENERGY chain support to NFT descriptor address mappings.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chain/denergy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing update in the chaind id lib and the comptroller/admin list (if needed)

@smol-ninja
Copy link
Copy Markdown
Member Author

missing update in the chaind id lib and the comptroller/admin list (if needed)

yeah. Also need to publish utils to npm and then update versions in package json files. I guess you are already on it right?

@smol-ninja
Copy link
Copy Markdown
Member Author

@andreivladbrg a reminder to merge this before publishing release

@andreivladbrg andreivladbrg merged commit d09888e into main Mar 23, 2026
15 of 17 checks passed
@andreivladbrg andreivladbrg deleted the chain/denergy branch March 23, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants