Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions pkg/ncmpcpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
[mirrors]
http://github.com/arybczak/ncmpcpp/archive/b7da5d1b9af1f3b0022c1f7daa0c7d12ae72a21d.tar.gz

[vars]
filesize=219516
sha512=8dd78f463811826729cb1498a7ccc4bff49393e88adb80260ad499623cf4ecdce5b405c1d91ca03f0b34bb7f5329124cb7a0541dbb880be2a634b057af93b9aa
pkgver=1
tarball=ncmpcpp-b7da5d1b9af1f3b0022c1f7daa0c7d12ae72a21d.tar.gz
tardir=ncmpcpp-b7da5d1b9af1f3b0022c1f7daa0c7d12ae72a21d

[deps]
boost
gnu-readline
libmpdclient

[deps.host]
automake

[build]

[ -n "$CROSS_COMPILE" ] && \
xconfflags="--host=$($CC -dumpmachine) \
--with-sysroot=$butch_root_dir"

# --------------------------------------------------------
# NOTE TO USERS: clock and visualizer are enabled by default
# on most distros, so they are to be expected. If you don't
# wish to use them, these flags can be deleted:
ADD_ONS="--enable-clock --enable-visualizer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to make this customizable, maybe you could just check if the environment var is already set, indicating that the user wants it changed, that way he doesnt need to edit the package itself

# --------------------------------------------------------

./autogen.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you run autogen.sh ? if it's possible, we rahter avoid that, since automake is a very heavy dependency. if it is because there's no configure script in the git checkout, maybe the author has tagged releases which include proper release tarballs with included configure script (related info: https://github.com/sabotage-linux/sabotage/wiki/Why-github-downloads-suck )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not ship with a configure script, and there isn't a "releases" page on his github.

The author has the configure script in his git-ignore. Looking back into commits of years ago you might be able to find a script but at that point its too old anyway.

Let me know what you want to do, and sorry if I misunderstood your comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's how i do it: i raise awareness of the issue ncmpcpp/ncmpcpp#263

is there a specific reason you want to have latest master, over the latest tagged release from 2 weeks ago ? as i already mentioned, releases are usually preferable over bleeding egde master downloads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

his releases page is here btw https://github.com/arybczak/ncmpcpp/releases
(click on code, then the releases button is visible)

CPPFLAGS="-D_GNU_SOURCE" CFLAGS="$optcflags" CXXFLAGS="$optcflags" \
LDFLAGS="$optldflags -Wl,-rpath-link=$butch_root_dir$butch_prefix/lib" \
./configure -C $ADD_ONS --with-boost=/opt/boost \
--prefix="$butch_prefix" --disable-nls $xconfflags

make V=1 -j$MAKE_THREADS
make DESTDIR="$butch_install_dir" install