Vulnerability Updates and Handlebars.dll Update#181
Open
an-d-uu wants to merge 1 commit intosachatrauwaen:masterfrom
Open
Vulnerability Updates and Handlebars.dll Update#181an-d-uu wants to merge 1 commit intosachatrauwaen:masterfrom
an-d-uu wants to merge 1 commit intosachatrauwaen:masterfrom
Conversation
an-d-uu
commented
Nov 17, 2021
an-d-uu
commented
- Update backbone from to 1.4.0 to correct Cross-site Scripting issue. (https://snyk.io/vuln/npm%3Abackbone)
- Update Handlebars.ddl from 1.10.1 to 1.11.5 which bring the .dll to the latest version before breaking changes in 2.x.
- Update handlebars.js from 4.0.5 to 4.7.7 to correct vulnerabilities. (https://snyk.io/test/npm/handlebars/4.0.5)
* Update backbone from to 1.4.0 to correct Cross-site Scripting issue. (https://snyk.io/vuln/npm%3Abackbone) * Update Handlebars.ddl from 1.10.1 to 1.11.5. * Update handlebars.js from 4.0.5 to 4.7.7 to correct vulnerabilities. (https://snyk.io/test/npm/handlebars/4.0.5)
|
Just an FYI: I am running a local test build of OC with Handlebars 2.1.6 compiled into it. There were literally only 2 changes needed to make it work. |
Collaborator
Are the changes you made the same as the ones in this PR? |
Author
|
No, it was a very easy change to make this work. I believe at the time it was failing one of the automated tests, but you are right that there were only 2 changes to make this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.