Open
Conversation
- Preserved all custom homepage features (mobile carousel, featured products) - Preserved custom SCSS styling changes - Updated to Cornerstone 6.16.2 with latest dependencies - Fixed Node.js compatibility issues - Theme builds and bundles successfully
…rved - Applied all JavaScript bug fixes and improvements - Updated all template files with new features and accessibility enhancements - Applied SCSS styling improvements and fixes - Updated language files with new translations - Added missing faceted-search templates - Preserved all custom homepage features and styling - Updated build tools and configuration files - Theme successfully builds and bundles - Fixed Node.js compatibility issues
- Restored header logo positioning and centering customizations - Restored header border styling (commented out border-bottom) - Restored mobile menu toggle positioning and colors - Restored product list focus-within hover effects - Restored product sale badge hover effects - Restored product swatch border-radius and margin customizations - Restored product view size chart table styling - Restored product details JavaScript customizations (date selector, celebration emoji) - All customizations now preserved while maintaining upgrade benefits
- Restored card-image-2 positioning and styling - Restored smooth transition effects (0.3s ease) - Restored proper z-index and absolute positioning - Restored hover state styling for card-figure - Product cards now properly fade between two images on hover - All customizations preserved while maintaining upgrade benefits
- Restored custom navUser-section styling with background and border-radius - Restored custom navUser-action styling with different font-weight and positioning - Restored custom cart styling with specific margin-top and padding - Restored custom countPill styling with commented out background and positioning - Restored custom cart label display settings - All navUser customizations now preserved while maintaining upgrade benefits
- Changed -backgroundColor to stencilColor('navUser-backgroundColor')
- Ensures compatibility with current theme variable system
- Stencil build now completes successfully with all customizations intact
- Changed 'Gift Certificates' to 'Gift Cards' in language files - Added navUser-backgroundColor variable definition in settings - Restored proper navUser background color variable usage - All customizations now properly preserved and working
- Changed navUser-backgroundColor from stencilColor() to #314a6d - Ensures the navUser section displays the correct background color - Build completes successfully with the specific color applied
- Created CUSTOMIZATIONS.md with detailed inventory of all customizations - Added restore-customizations.sh script for automated recovery - Created UPGRADE_CHECKLIST.md for future upgrade guidance - Documents 8 major customization areas with specific file locations - Includes testing checklist and troubleshooting guide - Ensures customizations can be preserved in future upgrades
- Removed duplicate store info section from footer template - Added missing Klaviyo initialization script to base layout - Ensures Klaviyo tracking works properly across all pages - Footer now displays store info only once as intended - All Klaviyo scripts are now intact and functional
- Added footer template customizations (duplicate info removal) - Added Klaviyo script integration details - Updated testing checklist to include new customizations - Updated critical files list to include new template files - Documentation now covers all 11 customization areas
- Fixed category.js: removed undefined showCategoryModal function and duplicate ariaNotifyNoProducts method - Fixed faceted-search.js: added missing ModalEvents import from modal factory - Fixed product-details.js: corrected import paths to use relative paths instead of useless path segments - Fixed gift-certificate.js: corrected ternary operator linebreak formatting - Fixed maintenanceMode.js: removed multiple empty lines - Fixed wishlist.js: removed invalid return statement from constructor - All ESLint errors resolved, code now passes linting checks
- Fixed jest.setup.js getClientRects implementation that was causing infinite recursion - The function was calling jQuery width/height methods which internally call getClientRects - Replaced with mock dimensions (100x100) to break the recursion loop - All tests now pass, including the previously failing modal.spec.js test - Resolves CI/CD test failure: 'Maximum call stack size exceeded'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A description about what this pull request implements and its purpose. Try to be detailed and describe any technical details to simplify the job of the reviewer and the individual on production support.
Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.