fix(time-picker): period switching on hour change from keyboard navigation#194
Merged
fix(time-picker): period switching on hour change from keyboard navigation#194
Conversation
- Fixed bug where PM/AM period would switch to AM when navigating hours with arrow keys or clicking hours in dropdown - Period now properly derives from existing 24-hour value instead of always defaulting to AM - When no value exists, defaults to current time's period for better UX - Matches native HTML time input behavior
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the time picker component where the period (AM/PM) would incorrectly switch when changing the hour value using keyboard navigation in 12-hour mode. The fix ensures that the current period is derived intelligently: first from the explicitly set period value, then from the existing hour if available, and finally from the current system time as a fallback.
Key Changes:
- Added block scope to the "period" case in the switch statement for better variable scoping
- Improved period determination logic in hour input updates to prevent unintended AM/PM switches
- Applied the same period determination logic to the TimePickerHour component for consistency
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/registry/default/ui/time-picker.tsx | Fixed period switching logic in three locations: getSegmentValue switch case, updateTimeValue hour case, and onHourSelect callback |
| docs/public/r/styles/default/time-picker.json | Updated the bundled content string to match the time-picker.tsx changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.