feat: add data-slot attributes to data-table pagination and toolbar#267
Open
zhengshui wants to merge 1 commit intosadmann7:mainfrom
Open
feat: add data-slot attributes to data-table pagination and toolbar#267zhengshui wants to merge 1 commit intosadmann7:mainfrom
zhengshui wants to merge 1 commit intosadmann7:mainfrom
Conversation
Add data-slot attributes to the data-table pagination and toolbar components to make them easier to customize and identify. This allows users to easily target these components with CSS selectors for RTL support and other customizations. Closes sadmann7#143
Contributor
|
Someone is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
data-slotattributes to the data-table pagination and toolbar components to make them easier to customize and identify.This resolves issue #143 which requested distinctive identifiers for these components to help with RTL support and other customizations.
Changes
data-slot=data-table-paginationto the pagination component root divdata-slot=data-table-toolbarto the toolbar component root divVerification
Closes #143