fix(data-grid): right-pinned column borders and rerender on dir change #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sadmann7
commented
Jan 1, 2026
sadmann7
commented
- Fix border positioning for right-pinned columns (show on left side, not right)
- Fix missing borders between multiple right-pinned columns
- Add dir prop to DataGridRow memo comparison to fix RTL switching
- Add stretchColumns prop to DataGridRow memo comparison
- Refactor border logic into getColumnBorderVisibility utility function
- Rename function and properties for better boolean semantics
- Fix border positioning for right-pinned columns (show on left side, not right) - Fix missing borders between multiple right-pinned columns - Add dir prop to DataGridRow memo comparison to fix RTL switching - Add stretchColumns prop to DataGridRow memo comparison - Refactor border logic into getColumnBorderVisibility utility function - Rename function and properties for better boolean semantics
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes border rendering issues for right-pinned columns in the data grid and ensures proper re-rendering when direction or column stretching changes.
- Renamed
getCommonPinningStylestogetColumnPinningStylefor better semantic clarity (singular form) - Introduced
getColumnBorderVisibilityutility to centralize and fix border logic for right-pinned columns - Added
dirandstretchColumnsto DataGridRow memo comparison to fix RTL switching and column stretch toggling
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/data-table.ts | Renamed getCommonPinningStyles to getColumnPinningStyle |
| src/lib/data-grid.ts | Added getColumnBorderVisibility function and renamed getCommonPinningStyles to getColumnPinningStyle with parameter reordering |
| src/components/data-table/data-table.tsx | Updated function reference to use renamed getColumnPinningStyle |
| src/components/data-grid/data-grid.tsx | Updated imports, added border visibility logic to headers, reordered props passed to DataGridRow |
| src/components/data-grid/data-grid-row.tsx | Added dir and stretchColumns checks to memo comparison, added border visibility logic to cells, updated function references |
| public/r/data-table.json | Updated registry with renamed function in data-table component |
| public/r/data-table-filter-menu.json | Updated registry with renamed function |
| public/r/data-table-filter-list.json | Updated registry with renamed function |
| public/r/data-grid.json | Updated registry with new border logic and renamed functions in data-grid components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.