Skip to content

fix(data-grid): cell variants memo #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadmann7 merged 1 commit into from
Feb 4, 2026
Merged

fix(data-grid): cell variants memo #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/r/data-grid.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 8 additions & 2 deletions src/components/data-grid/data-grid-cell-variants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,10 @@ export function SelectCell<TData>({
const [value, setValue] = React.useState(initialValue);
const containerRef = React.useRef<HTMLDivElement>(null);
const cellOpts = cell.column.columnDef.meta?.cell;
const options = cellOpts?.variant === "select" ? cellOpts.options : [];
const options = React.useMemo(
() => (cellOpts?.variant === "select" ? cellOpts.options : []),
[cellOpts],
);
const optionByValue = React.useMemo(
() => new Map(options.map((option) => [option.value, option])),
[options],
Expand Down Expand Up @@ -1017,7 +1020,10 @@ export function MultiSelectCell<TData>({
const containerRef = React.useRef<HTMLDivElement>(null);
const inputRef = React.useRef<HTMLInputElement>(null);
const cellOpts = cell.column.columnDef.meta?.cell;
const options = cellOpts?.variant === "multi-select" ? cellOpts.options : [];
const options = React.useMemo(
() => (cellOpts?.variant === "multi-select" ? cellOpts.options : []),
[cellOpts],
);
const optionByValue = React.useMemo(
() => new Map(options.map((option) => [option.value, option])),
[options],
Expand Down
Loading