Add registry update script#87
Closed
Fbartoli wants to merge 9 commits intosafe-global:feat/registry-update-scriptfrom
Closed
Add registry update script#87Fbartoli wants to merge 9 commits intosafe-global:feat/registry-update-scriptfrom
Fbartoli wants to merge 9 commits intosafe-global:feat/registry-update-scriptfrom
Conversation
…nfig.json - Introduced a new script `update-registry.ts` for updating module registry JSON files. - Added a GitHub Actions workflow `update-registry.yml` to automate registry updates. - Updated `package.json` to include a new script command for registry updates and added `tsx` as a dependency. - Modified `tsconfig.json` to include the new script directory in the TypeScript compilation.
…ut frozen lockfile
- Added `tsx` as a dependency in `pnpm-lock.yaml`. - Updated `pnpm-lock.yaml` to include new esbuild packages for various platforms and architectures. - Refactored `update-registry.ts` for consistent single quotes and improved error messages. - Enhanced argument parsing and validation in `update-registry.ts` for better user feedback.
yagopv
reviewed
Jan 20, 2026
Comment on lines
+19
to
+40
| const MODULE_CONFIG: Record< | ||
| string, | ||
| { | ||
| dir: string; | ||
| contractName: string; | ||
| jsonFile: string; | ||
| supportedVersions: string[]; | ||
| } | ||
| > = { | ||
| allowance: { | ||
| dir: 'allowance-module', | ||
| contractName: 'AllowanceModule', | ||
| jsonFile: 'allowance-module.json', | ||
| supportedVersions: ['0.1.1'], | ||
| }, | ||
| 'social-recovery': { | ||
| dir: 'safe-recovery-module', | ||
| contractName: 'SocialRecoveryModule', | ||
| jsonFile: 'social-recovery-module.json', | ||
| supportedVersions: ['0.1.0'], | ||
| }, | ||
| }; |
Member
There was a problem hiding this comment.
This script only works with 2 modules and the hardcoded versions in the config, Is this intended?
Collaborator
There was a problem hiding this comment.
For now we want to enable only these two specific modules to be deployed via the automated scripts.
Member
|
Is it worth to verify the address using for example Etherscan to check if the contract is deployed and that is the correct one? |
dasanra
reviewed
Jan 21, 2026
yagopv
reviewed
Jan 21, 2026
| const data: ModuleDeployment = JSON.parse(content); | ||
|
|
||
| // Normalize address to checksum format (lowercase for consistency with existing entries) | ||
| const normalizedAddress = address; |
Member
There was a problem hiding this comment.
The address is not being normalized right? besides the comment above
Collaborator
There was a problem hiding this comment.
Completely and the comment is not really accurate, I was checking and assets hold checksummed addresses
dasanra
approved these changes
Jan 21, 2026
Collaborator
|
This PR will be finalized in #95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.