Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 37.37% 37.73% +0.36%
==========================================
Files 84 84
Lines 5108 5117 +9
==========================================
+ Hits 1909 1931 +22
+ Misses 3022 3009 -13
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Generalizes the registry configuration and URL parsing abstractions so registry interceptors can share common config/matching logic, and updates the NPM interceptor + parser to use the new interfaces.
Changes:
- Added shared registry config types (
registryConfig,registryConfigMap) and parser/package-info interfaces. - Refactored NPM registry interceptor and URL parser to use the new shared abstractions.
- Updated NPM URL parser tests to validate behavior via the new
packageInfointerface.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
proxy/interceptors/registry_config.go |
Introduces shared registry config + hostname matching helpers for reuse across ecosystems. |
proxy/interceptors/npm_url_parser.go |
Refactors NPM parsing to return a generic packageInfo and renames GitHub-related parsers to NPM-specific types. |
proxy/interceptors/npm_url_parser_test.go |
Updates tests to validate via interface getters and new parser type names. |
proxy/interceptors/npm_registry.go |
Switches NPM interceptor to use registryConfigMap lookup and generic parsing interface. |
proxy/interceptors/npm_registry_config.go |
Removes NPM-specific config type/lookup in favor of shared registry config logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Uh oh!
There was an error while loading. Please reload this page.