You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current version guesses PNG icons of some applications (e.g. Slack Desktop) to have size 1x1 because they are not in *x* directories.
Guess the size of such icons by PNG header.
I tried to avoid reading icon content at startup, because it possibly may cause fatal delay in some cases, for example, when /usr or home mounted over nfs.
Instead, inspectIconMeta is supposed to set 1x1 to indicate unknown size. Then, selection procedure will choose this icon if no other icons are found. Then, during runtime, only if some window match this icon, loadIconContentPNG actually reads the file.
Is this approach broken?
It sounds good, however it currently doesn't seem to work, at least not with vscodium, which stores it's icon at /usr/share/pixmaps/vscodium.png. With this PR the problem disappears.
So, why didn't my approach work? Perhaps you had other icons for VSCodium, which AltTab chose instead of the desired one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version guesses PNG icons of some applications (e.g. Slack Desktop) to have size 1x1 because they are not in
*x*directories.Guess the size of such icons by PNG header.