-
-
Notifications
You must be signed in to change notification settings - Fork 30
Don't fail if gphelp is not available #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Indeed, the separation between I am not sure it is a good idea to silently build if It seems a better idea to me to add an option to disable the docstrings. Then, if in a standard build
What do you think? |
I agree it would certainly be nice to still have the documentation available on those systems. But on the other hand it shouldn't come to surprising to users that the cypari methods don't have docs when their pari counterparts don't have docs as well. My use case is that I want So while this approach here is perhaps not the best, I hope it's good enough... |
I don't really know. I have that problem on gentoo (sagemath/sage#40663) and on Alpine (sagemath/sage#40561), and I think also on ubuntu 22 + 24. |
Since in cypari the pari documentation is compiled as docstrings, it makes a huge difference with gp. You can install gp and gphelp in any order and will have the interactive documentation available. While for cypari, gphelp must be there at compile time.
What about a user who uses cypari but not pari? The interactive documentation is advertized in cypari and your PR is breaking this promise.
It this a dependency problem, then why not install gphelp on those systems and make it a dependency of cypari?
This PR could possibly solve for your usecase but it is only making cypari worse. |
You could also simple reinstall cypari after installing gphelp....it's not like this takes a very long time or is super complicated.
Mhh, I'm not sure what this PR is breaking. Suppose a user has pari without gphelp installed. Then:
Once you have gphelp installed, you get the same result with this PR as before. So, for me, this is a net-positive. Note also that the readme only mentions "PARI/GP >= 2.9.4 (header files and library)" as requirements for installation, not also the docs of pari / gphelp. |
If gphelp is not available (which happens actually on a few linux distros that don't ship the docs of pari with the pari install), then the install of cypari just fails. With this, instead the compilation succeeds but the auto-generated functions don't have any docstrings. Perhaps not ideal, but still better than not being to install it at all.
Refs #184