Trac #31144: refresh the file polyhedron/plot.py

fixing some lgtm warnings about mutation of default option values

plus a partial flake8 cleanup

URL: https://trac.sagemath.org/31144
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): David Coudert

Author: Release Manager

src/sage/geometry/polyhedron/plot.py

@@ -122,7 +122,7 @@ def cyclic_sort_vertices_2d(Vlist):
                 break
         else:
             result += chain
-            chain = [ Vlist.pop() ]
+            chain = [Vlist.pop()]
     result += chain
     return result
 
@@ -182,16 +182,16 @@ def __init__(self, projection_point):
         self.psize = norm(pproj)
         if (self.psize).is_zero():
             raise ValueError("projection direction must be a non-zero vector.")
-        v = vector(RDF, [0.0]*(self.dim-1) + [-self.psize]) - pproj
+        v = vector(RDF, [0.0] * (self.dim - 1) + [-self.psize]) - pproj
         polediff = matrix(RDF, v).transpose()
-        denom = RDF((polediff.transpose()*polediff)[0][0])
+        denom = RDF((polediff.transpose() * polediff)[0][0])
         if denom.is_zero():
             self.house = identity_matrix(RDF, self.dim)
         else:
             house = identity_matrix(RDF, self.dim) \
             - 2*polediff*polediff.transpose()/denom   # Householder reflector
             # Make it preserve orientation (chirality):
-            self.house = diagonal_matrix(RDF,[1]*(self.dim - 1) + [-1] ) * house
+            self.house = diagonal_matrix(RDF, [1] * (self.dim - 1) + [-1]) * house
 
     def __call__(self, x):
         """
@@ -225,11 +225,11 @@ def __call__(self, x):
             (0.5, 0.0)
         """
         img = self.house * x
-        denom = self.psize-img[self.dim-1]
+        denom = self.psize - img[self.dim - 1]
         if denom.is_zero():
-            raise ValueError('Point cannot coincide with ' \
-                'coordinate singularity at ' + repr(x))
-        return vector(RDF, [img[i]/denom for i in range(self.dim-1)])
+            raise ValueError('Point cannot coincide with '
+                             'coordinate singularity at ' + repr(x))
+        return vector(RDF, [img[i] / denom for i in range(self.dim - 1)])
 
 
 class ProjectionFuncSchlegel():
@@ -359,7 +359,7 @@ def __init__(self, polyhedron, proj=projection_func_identity):
         self.parent_polyhedron = polyhedron
         self.coords = Sequence([])
         self.points = Sequence([])
-        self.lines  = Sequence([])
+        self.lines = Sequence([])
         self.arrows = Sequence([])
         self.polygons = Sequence([])
         self.polyhedron_ambient_dim = polyhedron.ambient_dim()
@@ -478,7 +478,7 @@ def schlegel(self, facet=None, position=None):
           from the barycenter of ``facet``. A value close to 0 will place the
           projection point close to the facet and a large value further away.
           If the given value is too large, an error is returned.
-          If no position is given, it takes the midpoint of the possible 
+          If no position is given, it takes the midpoint of the possible
           point of views along a line spanned by the barycenter of the facet
           and a valid point outside the facet.
 
@@ -530,12 +530,12 @@ def schlegel(self, facet=None, position=None):
         if position is not None and position <= 0:
             raise ValueError("'position' should be a positive number")
 
-        barycenter = ZZ.one()*sum([v.vector() for v in facet.vertices()]) / len(facet.vertices())
+        barycenter = ZZ.one() * sum([v.vector() for v in facet.vertices()]) / len(facet.vertices())
         locus_polyhedron = facet.stacking_locus()
         repr_point = locus_polyhedron.representative_point()
         if position is None:
             # Figure out a somehow canonical point of view inside the locus
-            # polyhedron 
+            # polyhedron
             from sage.geometry.polyhedron.constructor import Polyhedron
             the_ray = Polyhedron(vertices=[barycenter],
                                  rays=[repr_point - barycenter],
@@ -682,7 +682,7 @@ def _init_points(self, polyhedron):
             [0, 1, 2, 3]
         """
         for v in polyhedron.vertex_generator():
-            self.points.append( self.coord_index_of(v.vector()) )
+            self.points.append(self.coord_index_of(v.vector()))
 
     def _init_lines_arrows(self, polyhedron):
         """
@@ -703,9 +703,10 @@ def _init_lines_arrows(self, polyhedron):
         """
         obj = polyhedron.Vrepresentation()
         for i in range(len(obj)):
-            if not obj[i].is_vertex(): continue
+            if not obj[i].is_vertex():
+                continue
             for j in range(len(obj)):
-                if polyhedron.vertex_adjacency_matrix()[i,j] == 0:
+                if polyhedron.vertex_adjacency_matrix()[i, j] == 0:
                     continue
                 if i < j and obj[j].is_vertex():
                     l = [obj[i].vector(), obj[j].vector()]
@@ -743,8 +744,10 @@ def _init_area_2d(self, polyhedron):
 
         def adjacent_vertices(i):
             n = len(vertices)
-            if vertices[(i-1) % n].is_vertex(): yield vertices[(i-1) % n]
-            if vertices[(i+1) % n].is_vertex(): yield vertices[(i+1) % n]
+            if vertices[(i-1) % n].is_vertex():
+                yield vertices[(i-1) % n]
+            if vertices[(i+1) % n].is_vertex():
+                yield vertices[(i+1) % n]
 
         for i in range(len(vertices)):
             v = vertices[i]
@@ -755,7 +758,7 @@ def adjacent_vertices(i):
                     coords.append(a() + v())
 
         if polyhedron.n_lines() == 0:
-            self.polygons.append( self.coord_indices_of(coords) )
+            self.polygons.append(self.coord_indices_of(coords))
             return
 
         polygons = []
@@ -764,18 +767,18 @@ def adjacent_vertices(i):
             aline = next(polyhedron.line_generator())
             for shift in [aline(), -aline()]:
                 for i in range(len(coords)):
-                    polygons.append( [ coords[i-1],coords[i],
-                                       coords[i]+shift, coords[i-1]+shift ] )
+                    polygons.append([coords[i - 1], coords[i],
+                                     coords[i] + shift, coords[i - 1] + shift])
 
         if polyhedron.n_lines() == 2:
             [line1, line2] = [l for l in polyhedron.lines()]
             assert len(coords) == 1, "Can have only a single vertex!"
             v = coords[0]
             l1 = line1()
             l2 = line2()
-            polygons = [ [v-l1-l2, v+l1-l2, v+l1+l2, v-l1+l2] ]
+            polygons = [[v-l1-l2, v+l1-l2, v+l1+l2, v-l1+l2]]
 
-        polygons = [ self.coord_indices_of(p) for p in polygons ]
+        polygons = [self.coord_indices_of(p) for p in polygons]
         self.polygons.extend(polygons)
 
     def _init_solid_3d(self, polyhedron):
@@ -848,17 +851,17 @@ def adjacent_vertices(i):
             for shift in [aline(), -aline()]:
                 for coords in faces:
                     assert len(coords) == 2, "There must be two points."
-                    polygons.append( [ coords[0],coords[1],
-                                       coords[1]+shift, coords[0]+shift ] )
+                    polygons.append([coords[0], coords[1],
+                                     coords[1] + shift, coords[0] + shift])
 
         if polyhedron.n_lines() == 2:
             [line1, line2] = [l for l in polyhedron.line_generator()]
             l1 = line1()
             l2 = line2()
             for v in polyhedron.vertex_generator():
-                polygons.append( [v()-l1-l2, v()+l1-l2, v()+l1+l2, v()-l1+l2] )
+                polygons.append([v()-l1-l2, v()+l1-l2, v()+l1+l2, v()-l1+l2])
 
-        self.polygons.extend( [self.coord_indices_of(p) for p in polygons] )
+        self.polygons.extend([self.coord_indices_of(p) for p in polygons])
 
     def render_points_1d(self, **kwds):
         """
@@ -938,10 +941,10 @@ def render_outline_2d(self, **kwds):
         wireframe = []
         for l in self.lines:
             l_coords = self.coordinates_of(l)
-            wireframe.append( line2d(l_coords, **kwds) )
+            wireframe.append(line2d(l_coords, **kwds))
         for a in self.arrows:
             a_coords = self.coordinates_of(a)
-            wireframe.append( arrow(a_coords[0], a_coords[1], **kwds) )
+            wireframe.append(arrow(a_coords[0], a_coords[1], **kwds))
         return sum(wireframe)
 
     def render_fill_2d(self, **kwds):
@@ -958,7 +961,7 @@ def render_fill_2d(self, **kwds):
             0.8
         """
         poly = [polygon2d(self.coordinates_of(p), **kwds)
-                 for p in self.polygons]
+                for p in self.polygons]
         return sum(poly)
 
     def render_vertices_3d(self, **kwds):
@@ -990,7 +993,7 @@ def render_wireframe_3d(self, **kwds):
         wireframe = []
         for l in self.lines:
             l_coords = self.coordinates_of(l)
-            wireframe.append( line3d(l_coords, **kwds))
+            wireframe.append(line3d(l_coords, **kwds))
         for a in self.arrows:
             a_coords = self.coordinates_of(a)
             wireframe.append(arrow3d(a_coords[0], a_coords[1], **kwds))
@@ -1011,7 +1014,7 @@ def render_solid_3d(self, **kwds):
         N = max([-1] + [i for p in polys for i in p]) + 1
         return polygons3d(polys, self.coordinates_of(range(N)), **kwds)
 
-    def render_0d(self, point_opts={}, line_opts={}, polygon_opts={}):
+    def render_0d(self, point_opts=None, line_opts=None, polygon_opts=None):
         """
         Return 0d rendering of the projection of a polyhedron into
         2-dimensional ambient space.
@@ -1032,15 +1035,17 @@ def render_0d(self, point_opts={}, line_opts={}, polygon_opts={}):
             sage: print(Polyhedron(ieqs=[(1,)]).projection().render_0d().description())
             Point set defined by 1 point(s):    [(0.0, 0.0)]
         """
+        if point_opts is None:
+            point_opts = {}
         if isinstance(point_opts, dict):
             point_opts.setdefault('zorder', 2)
             point_opts.setdefault('pointsize', 10)
         if self.points:
-            return point2d([0,0], **point_opts)
+            return point2d([0, 0], **point_opts)
         else:
             return Graphics()
 
-    def render_1d(self, point_opts={}, line_opts={}, polygon_opts={}):
+    def render_1d(self, point_opts=None, line_opts=None, polygon_opts=None):
         """
         Return 1d rendering of the projection of a polyhedron into
         2-dimensional ambient space.
@@ -1060,6 +1065,10 @@ def render_1d(self, point_opts={}, line_opts={}, polygon_opts={}):
             Graphics object consisting of 2 graphics primitives
         """
         plt = Graphics()
+        if point_opts is None:
+            point_opts = {}
+        if line_opts is None:
+            line_opts = {}
         if isinstance(point_opts, dict):
             point_opts.setdefault('zorder', 2)
             point_opts.setdefault('pointsize', 10)
@@ -1069,7 +1078,7 @@ def render_1d(self, point_opts={}, line_opts={}, polygon_opts={}):
             plt += self.render_line_1d(**line_opts)
         return plt
 
-    def render_2d(self, point_opts={}, line_opts={}, polygon_opts={}):
+    def render_2d(self, point_opts=None, line_opts=None, polygon_opts=None):
         """
         Return 2d rendering of the projection of a polyhedron into
         2-dimensional ambient space.
@@ -1088,6 +1097,12 @@ def render_2d(self, point_opts={}, line_opts={}, polygon_opts={}):
             Graphics object consisting of 17 graphics primitives
          """
         plt = Graphics()
+        if point_opts is None:
+            point_opts = {}
+        if line_opts is None:
+            line_opts = {}
+        if polygon_opts is None:
+            polygon_opts = {}
         if isinstance(point_opts, dict):
             point_opts.setdefault('zorder', 2)
             point_opts.setdefault('pointsize', 10)
@@ -1100,7 +1115,7 @@ def render_2d(self, point_opts={}, line_opts={}, polygon_opts={}):
             plt += self.render_fill_2d(**polygon_opts)
         return plt
 
-    def render_3d(self, point_opts={}, line_opts={}, polygon_opts={}):
+    def render_3d(self, point_opts=None, line_opts=None, polygon_opts=None):
         """
         Return 3d rendering of a polyhedron projected into
         3-dimensional ambient space.
@@ -1146,6 +1161,12 @@ def render_3d(self, point_opts={}, line_opts={}, polygon_opts={}):
         pplt = None
         lplt = None
         pgplt = None
+        if point_opts is None:
+            point_opts = {}
+        if line_opts is None:
+            line_opts = {}
+        if polygon_opts is None:
+            polygon_opts = {}
         if isinstance(point_opts, dict):
             point_opts.setdefault('width', 3)
             pplt = self.render_vertices_3d(**point_opts)
@@ -1341,10 +1362,10 @@ def _tikz_2d(self, scale, edge_color, facet_color, opacity, vertex_color, axis):
         edges = ''
         for vert in self.points:
             v = self.coords[vert]
-            v_vect = str(['%.5f' % i for i in v]).replace('\'','')
+            v_vect = str(['%.5f' % i for i in v]).replace('\'', '')
             v_vect = v_vect.replace('[', '(')
             v_vect = v_vect.replace(']', ')')
-            tag = '%s' %v_vect
+            tag = '%s' % v_vect
             node = "\\node[%s] at %s     {};\n" % ('vertex', tag)
             coord = '\\coordinate %s at %s;\n' % (tag, tag)
             dict_drawing[vert] = node, coord, tag
@@ -1362,7 +1383,7 @@ def _tikz_2d(self, scale, edge_color, facet_color, opacity, vertex_color, axis):
         tikz_pic += '\t[scale=%f,\n' % scale
         tikz_pic += '\tback/.style={loosely dotted, thin},\n'
         tikz_pic += '\tedge/.style={color=%s, thick},\n' % edge_color
-        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color,opacity)
+        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color, opacity)
         tikz_pic += '\tvertex/.style={inner sep=1pt,circle,draw=%s!25!black,' % vertex_color
         tikz_pic += 'fill=%s!75!black,thick}]\n%%\n%%\n' % vertex_color
 
@@ -1480,10 +1501,10 @@ def _tikz_2d_in_3d(self, view, angle, scale, edge_color, facet_color,
         edges = ''
         for vert in self.points:
             v = self.coords[vert]
-            v_vect = str(['%.5f' % i for i in v]).replace('\'','')
-            v_vect = v_vect.replace('[','(')
-            v_vect = v_vect.replace(']',')')
-            tag = '%s' %v_vect
+            v_vect = str(['%.5f' % i for i in v]).replace('\'', '')
+            v_vect = v_vect.replace('[', '(')
+            v_vect = v_vect.replace(']', ')')
+            tag = '%s' % v_vect
             node = "\\node[%s] at %s     {};\n" % ('vertex', tag)
             coord = '\\coordinate %s at %s;\n' % (tag, tag)
             dict_drawing[vert] = node, coord, tag
@@ -1507,7 +1528,7 @@ def _tikz_2d_in_3d(self, view, angle, scale, edge_color, facet_color,
         tikz_pic += '\tscale=%f,\n' % scale
         tikz_pic += '\tback/.style={loosely dotted, thin},\n'
         tikz_pic += '\tedge/.style={color=%s, thick},\n' % edge_color
-        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color,opacity)
+        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color, opacity)
         tikz_pic += '\tvertex/.style={inner sep=1pt,circle,draw=%s!25!black,' % vertex_color
         tikz_pic += 'fill=%s!75!black,thick}]\n%%\n%%\n' % vertex_color
 
@@ -1653,7 +1674,7 @@ def _tikz_3d_in_3d(self, view, angle, scale, edge_color,
             A = facets[index_facet].vector()[1:]
             B = facets[index_facet].vector()[0]
             for v in self.points:
-                if A*self.coords[v]+B < 0.0005 and v not in back_vertices:
+                if A * self.coords[v] + B < 0.0005 and v not in back_vertices:
                     back_vertices += [v]
 
         # Creates the nodes, coordinate and tag for every vertex of the polytope.
@@ -1664,12 +1685,12 @@ def _tikz_3d_in_3d(self, view, angle, scale, edge_color,
 
         for vert in self.points:
             v = self.coords[vert]
-            v_vect = str(['%.5f' % i for i in v]).replace('\'','')
-            v_vect = v_vect.replace('[','(')
-            v_vect = v_vect.replace(']',')')
-            tag = '%s' %v_vect
+            v_vect = str(['%.5f' % i for i in v]).replace('\'', '')
+            v_vect = v_vect.replace('[', '(')
+            v_vect = v_vect.replace(']', ')')
+            tag = '%s' % v_vect
             node = "\\node[%s] at %s     {};\n" % ('vertex', tag)
-            coord = '\\coordinate %s at %s;\n' %(tag, tag)
+            coord = '\\coordinate %s at %s;\n' % (tag, tag)
             dict_drawing[vert] = node, coord, tag
 
         # Separate the edges between back and front
@@ -1684,10 +1705,14 @@ def _tikz_3d_in_3d(self, view, angle, scale, edge_color,
 
             # The back edge has to be between two vertices in the Back
             # AND such that the 2 facets touching them are in the Back
-            if index1 in back_vertices and index2 in back_vertices and len(H_v12)==2:
-                back_part += "\\draw[%s,back] %s -- %s;\n" % ('edge', dict_drawing[index1][2], dict_drawing[index2][2])
+            if index1 in back_vertices and index2 in back_vertices and len(H_v12) == 2:
+                back_part += "\\draw[%s,back] %s -- %s;\n" % ('edge',
+                                                              dict_drawing[index1][2],
+                                                              dict_drawing[index2][2])
             else:
-                front_part += "\\draw[%s] %s -- %s;\n" % ('edge',dict_drawing[index1][2],dict_drawing[index2][2])
+                front_part += "\\draw[%s] %s -- %s;\n" % ('edge',
+                                                          dict_drawing[index1][2],
+                                                          dict_drawing[index2][2])
 
         # Start to write the output
         tikz_pic = ''
@@ -1701,7 +1726,7 @@ def _tikz_3d_in_3d(self, view, angle, scale, edge_color,
         tikz_pic += '\tscale=%f,\n' % scale
         tikz_pic += '\tback/.style={loosely dotted, thin},\n'
         tikz_pic += '\tedge/.style={color=%s, thick},\n' % edge_color
-        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color,opacity)
+        tikz_pic += '\tfacet/.style={fill=%s,fill opacity=%f},\n' % (facet_color, opacity)
         tikz_pic += '\tvertex/.style={inner sep=1pt,circle,draw=%s!25!black,' % vertex_color
         tikz_pic += 'fill=%s!75!black,thick}]\n%%\n%%\n' % vertex_color
 
@@ -1737,7 +1762,7 @@ def _tikz_3d_in_3d(self, view, angle, scale, edge_color,
         # Draw the vertices on top of the back-edges
         tikz_pic += '%%\n%%\n%% Drawing vertices in the back\n%%\n'
         for v in back_vertices:
-            if not v in front_vertices and v in dict_drawing:
+            if v not in front_vertices and v in dict_drawing:
                 tikz_pic += dict_drawing[v][0]
 
         # Draw the facets in the front by going in cycles for every facet.