-
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Steps to reproduce:
- Run the
demo_GridViewWidgetnotebook - goto the second example of "Interactive edition of Young tableaux"
- Replace 10 (or any value) by 9 (a wrong value)
- Reverse the change
Result:
- The modified cell stay dirty
Expected:
- All cells are clean
This might get more complex with more dirty cells.
It also don't change the set of visible addable/removable cells leading to potential exceptions.
See:
sage-combinat-widgets/sage_combinat_widgets/grid_view_editor.py
Lines 610 to 613 in dcd47e4
| # Success | |
| self.donottrack = True | |
| self.set_value(result) | |
| self.donottrack = False |
sage-combinat-widgets/sage_combinat_widgets/grid_view_editor.py
Lines 405 to 414 in dcd47e4
| self.reset_dirty() | |
| if self.donottrack: | |
| return | |
| old_val = change.old | |
| new_val = change.new | |
| actually_changed = (id(new_val) != id(old_val)) | |
| if actually_changed: | |
| self.push_history(old_val) | |
| self.compute() | |
| self.draw() |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels

