Skip to content

Commit 29f8555

Browse files
committed
fix d <= 0 -> d < 0
1 parent fedfcdc commit 29f8555

File tree

4 files changed

+16
-20
lines changed

4 files changed

+16
-20
lines changed

src/sage/rings/polynomial/polynomial_element.pyx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7667,12 +7667,11 @@ cdef class Polynomial(CommutativePolynomial):
76677667

76687668
cdef unsigned long d
76697669
if degree is not None:
7670-
if degree <= 0:
7670+
if degree < 0:
7671+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
7672+
d = degree
7673+
if d != degree:
76717674
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
7672-
try:
7673-
d = degree
7674-
except ValueError:
7675-
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
76767675
if len(v) < degree+1:
76777676
v.reverse()
76787677
v = [self.base_ring().zero()]*(degree+1-len(v)) + v

src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1827,12 +1827,11 @@ cdef class Polynomial_integer_dense_flint(Polynomial):
18271827
cdef Polynomial_integer_dense_flint res = self._new()
18281828
cdef unsigned long d
18291829
if degree is not None:
1830-
if degree <= 0:
1830+
if degree < 0:
1831+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
1832+
d = degree
1833+
if d != degree:
18311834
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
1832-
try:
1833-
d = degree
1834-
except ValueError:
1835-
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
18361835
# FLINT expects length
18371836
fmpz_poly_reverse(res._poly, self._poly, d+1)
18381837
else:

src/sage/rings/polynomial/polynomial_zmod_flint.pyx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -815,12 +815,11 @@ cdef class Polynomial_zmod_flint(Polynomial_template):
815815
cdef Polynomial_zmod_flint res = self._new()
816816
cdef unsigned long d
817817
if degree is not None:
818-
if degree <= 0:
818+
if degree < 0:
819+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
820+
d = degree
821+
if d != degree:
819822
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
820-
try:
821-
d = degree
822-
except ValueError:
823-
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
824823
nmod_poly_reverse(&res.x, &self.x, d+1) # FLINT expects length
825824
else:
826825
nmod_poly_reverse(&res.x, &self.x, nmod_poly_length(&self.x))

src/sage/rings/polynomial/polynomial_zz_pex.pyx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -538,12 +538,11 @@ cdef class Polynomial_ZZ_pEX(Polynomial_template):
538538
# When a degree has been supplied, ensure it is a valid input
539539
cdef unsigned long d
540540
if degree is not None:
541-
if degree <= 0:
541+
if degree < 0:
542+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
543+
d = degree
544+
if d != degree:
542545
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
543-
try:
544-
d = degree
545-
except ValueError:
546-
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
547546
ZZ_pEX_reverse_hi(r.x, (<Polynomial_ZZ_pEX> self).x, d)
548547
else:
549548
ZZ_pEX_reverse(r.x, (<Polynomial_ZZ_pEX> self).x)

0 commit comments

Comments
 (0)