Skip to content

Commit 422311a

Browse files
author
Release Manager
committed
gh-39281: fix and activate the ruff check for F811 this is about bad imports : Redefinition of unused something from line xxx ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: #39281 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
2 parents 880ee64 + 56cbf63 commit 422311a

File tree

10 files changed

+6
-17
lines changed

10 files changed

+6
-17
lines changed

src/sage/algebras/weyl_algebra.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from sage.misc.latex import latex, LatexExpr
2222
from sage.misc.lazy_attribute import lazy_attribute
2323
from sage.misc.misc_c import prod
24-
from sage.structure.element import Element
2524
from sage.structure.parent import Parent
2625
from sage.structure.unique_representation import UniqueRepresentation
2726
from sage.categories.action import Action

src/sage/categories/basic.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
from sage.categories.principal_ideal_domains import PrincipalIdealDomains
4848
from sage.categories.euclidean_domains import EuclideanDomains
4949
from sage.categories.unique_factorization_domains import UniqueFactorizationDomains
50-
from sage.categories.complete_discrete_valuation import CompleteDiscreteValuationRings
5150

5251
from sage.categories.fields import Fields
5352
from sage.categories.quotient_fields import QuotientFields

src/sage/coding/guruswami_sudan/gs_decoder.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,17 @@
1414
- David Lucas, ported the original implementation in Sage
1515
"""
1616

17-
#*****************************************************************************
17+
# ****************************************************************************
1818
# Copyright (C) 2015 David Lucas <[email protected]>
1919
# 2015 Johan S. R. Nielsen <[email protected]>
2020
#
2121
# This program is free software: you can redistribute it and/or modify
2222
# it under the terms of the GNU General Public License as published by
2323
# the Free Software Foundation, either version 2 of the License, or
2424
# (at your option) any later version.
25-
# http://www.gnu.org/licenses/
26-
#*****************************************************************************
25+
# https://www.gnu.org/licenses/
26+
# ****************************************************************************
2727

28-
from sage.arith.misc import integer_floor as floor
2928
from sage.coding.grs_code import GeneralizedReedSolomonCode
3029
from sage.rings.integer_ring import ZZ
3130
from sage.coding.decoder import Decoder

src/sage/modules/with_basis/representation.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from sage.misc.cachefunc import cached_method
2222
from sage.structure.element import Element
2323
from sage.combinat.free_module import CombinatorialFreeModule, CombinatorialFreeModule_Tensor
24-
from sage.modules.with_basis.subquotient import SubmoduleWithBasis
2524
from sage.categories.modules import Modules
2625
from sage.matrix.constructor import matrix
2726
from sage.modules.free_module_element import vector

src/sage/rings/finite_rings/integer_mod_ring.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
from sage.arith.misc import CRT_basis
7070
from sage.rings.ring import Field, CommutativeRing
7171
from sage.misc.mrange import cartesian_product_iterator
72-
import sage.rings.ring as ring
7372
import sage.rings.abc
7473
from sage.rings.finite_rings import integer_mod
7574
import sage.rings.integer as integer
@@ -2030,7 +2029,7 @@ def crt(v):
20302029
1027
20312030
"""
20322031
if len(v) == 0:
2033-
return IntegerModRing(1)(1)
2032+
return IntegerModRing(1).one()
20342033
x = v[0]
20352034
for i in range(1, len(v)):
20362035
x = x.crt(v[i])

src/sage/rings/polynomial/polynomial_ring.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ def is_PolynomialRing(x):
230230
sage: type(R)
231231
<class 'sage.rings.polynomial.multi_polynomial_libsingular.MPolynomialRing_libsingular'>
232232
"""
233-
from sage.misc.superseded import deprecation
234233
deprecation(38266,
235234
"The function is_PolynomialRing is deprecated; "
236235
"use 'isinstance(..., PolynomialRing_generic)' instead.")

src/sage/schemes/curves/affine_curve.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@
141141
from sage.rings.polynomial.multi_polynomial_element import degree_lowest_rational_function
142142
from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
143143
from sage.rings.rational_field import RationalField
144-
from sage.rings.infinity import infinity
145144

146145
from sage.schemes.affine.affine_space import AffineSpace, AffineSpace_generic
147146
from sage.schemes.affine.affine_subscheme import (AlgebraicScheme_subscheme_affine,

src/sage/schemes/elliptic_curves/ell_point.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,8 @@
140140
from sage.rings.integer_ring import ZZ
141141
from sage.rings.padics.precision_error import PrecisionError
142142
from sage.rings.rational_field import QQ
143-
from sage.rings.finite_rings.integer_mod import Mod
144143
from sage.rings.real_mpfr import RealField, RR
145144
from sage.rings.quotient_ring import QuotientRing_generic
146-
import sage.groups.generic as generic
147145

148146
from sage.structure.element import AdditiveGroupElement
149147
from sage.structure.sequence import Sequence

src/sage/symbolic/expression_conversions.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from sage.misc.lazy_import import lazy_import
2424
from sage.symbolic.ring import SR
2525
from sage.structure.element import Expression
26-
from sage.functions.all import exp
26+
from sage.functions.log import exp
2727
from sage.symbolic.operators import arithmetic_operators, relation_operators, FDerivativeOperator, add_vararg, mul_vararg
2828
from sage.rings.number_field.number_field_element_base import NumberFieldElement_base
2929
from sage.rings.universal_cyclotomic_field import UniversalCyclotomicField
@@ -1651,7 +1651,6 @@ class Exponentialize(ExpressionTreeWalker):
16511651
# the same canned results dictionary at each call.
16521652
from sage.calculus.var import function
16531653
from sage.functions.hyperbolic import sinh, cosh, sech, csch, tanh, coth
1654-
from sage.functions.log import exp
16551654
from sage.functions.trig import sin, cos, sec, csc, tan, cot
16561655
from sage.rings.integer import Integer
16571656
from sage.symbolic.constants import e, I
@@ -1749,7 +1748,6 @@ def composition(self, ex, op):
17491748
sage: s.composition(q, q.operator())
17501749
(cos(b) + I*sin(b))*e^a
17511750
"""
1752-
from sage.functions.log import exp
17531751
if op is not exp:
17541752
# return super().composition(ex, op)
17551753
return op(*[self(oper) for oper in ex.operands()])

src/tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ passenv = RUFF_OUTPUT_FORMAT
311311
# 1 F402 [ ] Import `factor` from line 259 shadowed by loop variable
312312
# 1 PLC0208 [*] Use a sequence type instead of a `set` when iterating over values
313313
#
314-
commands = ruff check --ignore E402,E721,E731,E741,E742,E743,F401,F402,F403,F405,F811,F821,F841,I001,PLC0206,PLC0208,PLC2401,PLC3002,PLE0302,PLR0124,PLR0402,PLR0911,PLR0912,PLR0913,PLR0915,PLR1704,PLR1711,PLR1714,PLR1736,PLR2004,PLR5501,PLW0120,PLW0127,PLW0211,PLW0602,PLW0603,PLW0642,PLW1508,PLW1510,PLW2901,PLW3301 {posargs:{toxinidir}/sage/}
314+
commands = ruff check --ignore E402,E721,E731,E741,E742,E743,F401,F402,F403,F405,F821,F841,I001,PLC0206,PLC0208,PLC2401,PLC3002,PLE0302,PLR0124,PLR0402,PLR0911,PLR0912,PLR0913,PLR0915,PLR1704,PLR1711,PLR1714,PLR1736,PLR2004,PLR5501,PLW0120,PLW0127,PLW0211,PLW0602,PLW0603,PLW0642,PLW1508,PLW1510,PLW2901,PLW3301 {posargs:{toxinidir}/sage/}
315315

316316
[flake8]
317317
rst-roles =

0 commit comments

Comments
 (0)