You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-40839: Fix in label synchronization bot according to issue #40758
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes#12345". -->
This PR fixes#40758.
> The action
https://github.com/sagemath/sage/blob/develop/.github/sync_labels.py
should not change "needs work" (maybe "needs info" too, but we don't use
that as much so I'm not sure if it has different behaviour currently) to
"needs review" when the commit message matches the default message for a
merge commit.
Alternatives Considered
This is achieved by ignoring merge commits when the latest commit date
is determined in case a `s: needs_work` label exists. Since `s:
needs_work` persists if there is a more recent review requesting changes
this should solve the problem.
> Merging develop should still trigger a new CI run. I don't imagine
that this change would effect that though.
This remains unchanged.
> Check whether merging from the command line with git and merging from
the GitHub web interface generate the same default merge commit
messages.
In both cases, the predefined message begins with `Merge` and contains
the word `develop`. I just check that this is valid. However, note that
the user (at least in the in the command line) has the option of
changing the messages. Therefore, we generally cannot detect merge
commits exactly.
This PR also implements a new method `test_method` just for test
purposes. This allows to run arbitrary methods of the class from the
command line.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - #12345: short description why this is a dependency -->
<!-- - #34567: ... -->
URL: #40839
Reported by: Sebastian Oehms
Reviewer(s): Sebastian Oehms, Vincent Macri
0 commit comments