-
-
Notifications
You must be signed in to change notification settings - Fork 654
Use python3 -m sage.doctest
in doctest results report if not using sage-runtests
#40332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview for this PR (built with commit 7ff88f2; changes) is ready! 🎉 |
""" | ||
cmd = "sage -t" | ||
cmd = "sage-runtests" if "sage-runtests" in argv[0] else "python3 -m sage.doctest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change it from sage -t
to sage-runtests
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to minimize the wrapping layers - I didn't make it python3 -m sage.doctest
unconditionally because sage may not be installed in the system python namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay!
CI is failing now, seems like a typo in the merge resolution. |
Thanks, fixed. |
Follow-up at #40704 |
The test failures are now reported as
which isn't a command that I can easily run from the repo root. IMHO thats a definite regression, it is much clearer to output a command that you can just run to re-run the test |
That's easy to change, but note that, depending on your PATH, |
a full path would be ok with me, I don't understand why we need a different command though (but then thats arguably less important) |
What about the relative path from the root? So src/bin/sage-runtests ? I think it's most common to execute stuff from the root, at least CI is doing this. |
Instead of
sage -t
, which no longer works with meson