Skip to content

add missing double colon #40551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

add missing double colon #40551

merged 1 commit into from
Aug 16, 2025

Conversation

mantepse
Copy link
Contributor

@mantepse mantepse commented Aug 7, 2025

Sphinx needs a double colon befor an indented block (of example code).

Copy link

github-actions bot commented Aug 7, 2025

Documentation preview for this PR (built with commit d6447ee; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@user202729
Copy link
Contributor

what happened before this change? Why does the linter (which checks for RST syntax validity) not catch this?

@dimpase
Copy link
Member

dimpase commented Aug 9, 2025

what happened before this change? Why does the linter (which checks for RST syntax validity) not catch this?

maybe it's such a vintage bug that the linter considers it a gold standard :-)

14ac8cb2e497 (Mike Hansen  2009-11-19 08:25:36 -0800  675)  element?  I.e. should the result be ``0`` or ``B[0]``?

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 10, 2025
sagemathgh-40551: add missing double colon
    
Sphinx needs a double colon befor an indented block (of example code).
    
URL: sagemath#40551
Reported by: Martin Rubey
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2025
sagemathgh-40551: add missing double colon
    
Sphinx needs a double colon befor an indented block (of example code).
    
URL: sagemath#40551
Reported by: Martin Rubey
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 13, 2025
sagemathgh-40551: add missing double colon
    
Sphinx needs a double colon befor an indented block (of example code).
    
URL: sagemath#40551
Reported by: Martin Rubey
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 14, 2025
sagemathgh-40551: add missing double colon
    
Sphinx needs a double colon befor an indented block (of example code).
    
URL: sagemath#40551
Reported by: Martin Rubey
Reviewer(s): David Coudert
@vbraun vbraun merged commit 16d9fa1 into sagemath:develop Aug 16, 2025
24 of 25 checks passed
@mantepse mantepse deleted the patch-1 branch August 18, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants