Deprecate name=('a',) for FiniteField #40949
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
user202729
commented
Oct 1, 2025
| sage: GF(7^2, name='aa') | ||
| Finite Field in aa of size 7^2 | ||
| sage: GF(7, name=('aa',)) | ||
| Finite Field of size 7 |
There was a problem hiding this comment.
this ought to fail (warn), but it doesn't. Why?
|
Documentation preview for this PR (built with commit 7b59ba9; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolynomialRing(ZZ, 1, name=("x",))is an error, so it should make sense to deprecate passing a list/tuple asname.Triggered by #40947.
On the other hand, it is explicitly legal (see
normalize_names) to sayPolynomialRing(ZZ, 2, names="x,y")(split by comma), so deprecating passing a string asnamesis probably not a good idea (for consistency).📝 Checklist
⌛ Dependencies
#40947