-
-
Notifications
You must be signed in to change notification settings - Fork 711
Call sig_block() in integral callback #40980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Call sig_block() in integral callback #40980
Conversation
|
Documentation preview for this PR (built with commit b66d785; changes) is ready! 🎉 |
|
Just got this: https://github.com/sagemath/sage/actions/runs/18576442855/job/52962606814 so the increase in tolerance would be not enough. Maybe there is an actual issue here? |
|
sounds like one of these extremely-difficult-to-debug issue. Given that I also can't reproduce it internally, I'd guess that GitHub CI machines are some virtual machine thing and may need to compete with other virtual machines concurrently running, which would explain the (extreme) fluctuation. |
|
I suspect garbage collector. Let's see if #41072 helps. |
|
that 2.1566 is unrelated to the change in this pull request (add |
sagemathgh-40980: Call sig_block() in integral callback Fix sagemath#30379 . The implementation mimic `acb_calc_func_callback`. also increase tolerance for a few parts, since the CI system is somewhat unreliable (I've seen a 2.00 being 2.04). I guess 0.1s is still considered almost imperceptible by human. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40980 Reported by: user202729 Reviewer(s):
sagemathgh-40980: Call sig_block() in integral callback Fix sagemath#30379 . The implementation mimic `acb_calc_func_callback`. also increase tolerance for a few parts, since the CI system is somewhat unreliable (I've seen a 2.00 being 2.04). I guess 0.1s is still considered almost imperceptible by human. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40980 Reported by: user202729 Reviewer(s):
|
There is a tolerance missing on this test |
This has been fixed now in my PR #41263. And seems unrelevant with this PR. So I set it to positive. |
Fix #30379 .
The implementation mimic
acb_calc_func_callback.also increase tolerance for a few parts, since the CI system is somewhat unreliable (I've seen a 2.00 being 2.04). I guess 0.1s is still considered almost imperceptible by human.
📝 Checklist
⌛ Dependencies