Skip to content

Conversation

user202729
Copy link
Contributor

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Oct 5, 2025

Documentation preview for this PR (built with commit ccad5c4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

user202729 commented Oct 5, 2025

looks like the "deploy documentation" step is run using the workflow definition in the repository instead of in the pull request, so it doesn't show up in this pull request itself.

https://github.com/sagemath/sage/actions/runs/18261574459

you can nonetheless see the debug print at https://github.com/sagemath/sage/actions/runs/18260896785/job/51988639573?pr=40986#step:12:82

@user202729
Copy link
Contributor Author

(Line: 28, Col: 3): The workflow must contain at least one job with no dependencies.

sure enough, it doesn't work like that. If only GitHub workflows were easier to work with.

@user202729 user202729 force-pushed the action-notify-send branch 2 times, most recently from c06d2df to ccad5c4 Compare October 7, 2025 14:43
@user202729 user202729 marked this pull request as ready for review October 7, 2025 14:43
@user202729
Copy link
Contributor Author

should be correct now. This is surprisingly hard to get right…

the "doc-publish" workflow is triggered from the develop branch, so the effect won't be seen until it is merged into develop.

here are some test

@user202729 user202729 requested review from tobiasdiez and kwankyu and removed request for tobiasdiez October 7, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant