Fix no-space-left failures in doc-build workflow #41248
Conversation
kwankyu
changed the title
kwankyu
changed the title
|
Documentation preview for this PR (built with commit 3a859e5; changes) is ready! 🎉 |
|
It seems OK now. why block this? |
What is "it"?
Are you asking why this PR is a blocker? The doc-build workflow is failing: https://github.com/sagemath/sage/actions/workflows/doc-build.yml This PR fixes it, and needs to be merged quickly. Hence a blocker. |
|
https://doc-pr-41248--sagemath.netlify.app/html/en/ |
vincentmacri
added
p: CI fix
|
Blocker label isn't necessary since we have the CI fix label now. |
|
Thank you! |
|
Thanks!
Let me clarify. "p: CI Fix" priority label is for PRs that needs to be merged to the PR branch before CI workflows run (since otherwise CI workflows would fail). "p: blocker" priority label is for PRs that should be merged to the next release since it is very critical for further development. Hence the release manager (@vbraun) prioritize these PRs when he starts to select positively-reviewed PRs to merge to the next release. If I remember correctly:
The caveat is that a PR making changes to github workflows is not effective even if it has "p: CI Fix" label since github action machinery uses workflows from the PR branch (this PR is, of course, different from the PR making changes to github workflows). Hence "p: blocker" is the label this PR should get. These things should be explained in https://doc-release--sagemath.netlify.app/html/en/developer/review |
I'm not quite sure I understand the point of "p: CI Fix" then, but okay. Does it only help for CI fixes that do not change code under
Yes. There are many things that ought to be better explained in our developer guide. |
Well, the label is not to fix the workflows, but to fix other things so that CI workflows work.
Close. "p: CI Fix" is effective for all CI fixes that make changes to files other than |
Good to know! I thought "p: CI Fix" was effective for all changes. Sorry about that! |
|
Indeed, that is a very subtle point. By the way, I think the label should be renamed to "p: CI fix" since all other labels are in small letters. |
Co-authored-by: Vincent Macri <[email protected]>
|
The other doc build workflows (
I applied the same fix to these workflows too. |
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#40929 Test: https://github.com/kwankyu/sage/actions/runs/19849361332/job/56872883527 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41248 Reported by: Kwankyu Lee Reviewer(s): Chenxin Zhong, Kwankyu Lee, Vincent Macri
Fixes #40929
Test: https://github.com/kwankyu/sage/actions/runs/19849361332/job/56872883527
📝 Checklist
⌛ Dependencies