Fix for projective curve pickling, enabling more tests for function field Jacobians #41265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmacri
commented
Dec 5, 2025
| gs = self.ambient_space().gens() | ||
| for i in range(self.ngens()): | ||
| if gs[i] not in ideal: | ||
| self._open_affine = self.affine_patch(i) |
Member
Author
There was a problem hiding this comment.
All changes in this file before this line are just formatting changes from ruff.
vincentmacri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pickling issue I encountered while working on some function field improvements. This lets us enable some additional tests for Jacobians of function fields that were disabled due to a pickling issue with projective curves.
Previously the
_open_affineand_map_from_function_fieldproperties of projective curves would fail to pickle. We solve this by not storing them in the pickle since they are easy to recompute.📝 Checklist
⌛ Dependencies