make some cases of opening files dramatically faster, especially when not in home directory

Author: williamstein

src/packages/frontend/client/project.ts

@@ -467,7 +467,24 @@ export class ProjectClient {
     project_id: string;
     path: string;
   }): Promise<string> {
-    return (await this.api(opts.project_id)).realpath(opts.path);
+    const real = (await this.api(opts.project_id)).realpath(opts.path);
+    return real;
+  }
+
+  async isdir({
+    project_id,
+    path,
+  }: {
+    project_id: string;
+    path: string;
+  }): Promise<boolean> {
+    const { stdout, exit_code } = await this.exec({
+      project_id,
+      command: "file",
+      args: ["-Eb", path],
+      err_on_exit: false,
+    });
+    return !exit_code && stdout.trim() == "directory";
   }
 
   // Add and remove a license from a project.  Note that these

src/packages/frontend/components/smart-anchor-tag.tsx

@@ -110,7 +110,7 @@ function CoCalcURL({ href, title, children, project_id }) {
           project_id,
           decodeURI(target),
           !((e as any)?.which === 2 || e?.ctrlKey || e?.metaKey),
-          fragmentId
+          fragmentId,
         );
       } catch (err) {
         // loadTarget could fail, e.g., if the project_id is mangled.
@@ -358,15 +358,15 @@ function InternalRelativeLink({ project_id, path, href, title, children }) {
           target = join(
             "files",
             path ? path_split(path).head : "",
-            decodeURI(hrefPlain)
+            decodeURI(hrefPlain),
           );
         }
         loadTarget(
           "projects",
           project_id,
           target,
           !((e as any).which === 2 || e.ctrlKey || e.metaKey),
-          fragmentId
+          fragmentId,
         );
       }}
       title={title}
@@ -381,7 +381,7 @@ function loadTarget(
   project_id: string,
   target: string,
   switchTo: boolean,
-  fragmentId?: FragmentId
+  fragmentId?: FragmentId,
 ): void {
   if (!is_valid_uuid_string(project_id)) {
     throw Error(`invalid project id ${project_id}`);

src/packages/frontend/project/open-file.ts

@@ -50,7 +50,7 @@ export async function open_file(
   actions: ProjectActions,
   opts: OpenFileOpts,
 ): Promise<void> {
-  // console.log(opts);
+  // console.log("open_file: ", opts);
 
   if (opts.path.endsWith("/")) {
     actions.open_directory(opts.path);

src/packages/frontend/project/utils.ts

@@ -239,11 +239,15 @@ export function editor_id(project_id: string, path: string): string {
 // Also, if ~/ is somewhere in the path, start over at home.
 export function normalize(path: string): string {
   while (true) {
-    const i = path.indexOf("~/");
+    const pattern = "/~/";
+    const i = path.indexOf(pattern);
     if (i == -1) {
       break;
     }
-    path = path.slice(i + 2);
+    path = path.slice(i + pattern.length);
+  }
+  if (path.startsWith("~/")) {
+    path = path.slice(2);
   }
 
   path = os_path.normalize(path);

src/packages/frontend/project_actions.ts

@@ -3210,34 +3210,29 @@ export class ProjectActions extends Actions<ProjectStoreState> {
         if (store == null) {
           return; // project closed already
         }
+        // We check whether the path is a directory or not, first by checking if
+        // we have a recent directory listing in our cache, and if not, by calling
+        // isdir, which is a single exec.
+        let isdir;
         let { item, err } = store.get_item_in_path(last, parent_path);
         if (item == null || err) {
-          // Fetch again if error or nothing found
           try {
-            await this.fetch_directory_listing({
-              path: parent_path,
+            isdir = await webapp_client.project_client.isdir({
+              project_id: this.project_id,
+              path: normalize(full_path),
             });
-            const store = this.get_store();
-            if (store == null) {
-              // project closed
-              return;
-            }
-            const x = store.get_item_in_path(last, parent_path);
-            if (x.err) throw Error(x.err);
-            if (x.item == null) {
-              item = Map(); // creating file
-            } else {
-              item = x.item;
-            }
           } catch (err) {
+            // e.g., project is not running...
             alert_message({
               type: "error",
               message: `Error opening '${target}': ${err}`,
             });
             return;
           }
+        } else {
+          isdir = item.get("isdir");
         }
-        if (item.get("isdir")) {
+        if (isdir) {
           this.open_directory(full_path, change_history);
         } else {
           this.open_file({