feat: support empty req.url
#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable to me. |
|
This is now [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vite, we support
rewriteoption, which allows users to changereq.urlbefore it is passed tohttp-proxy-3.Some users were setting
req.url: ''with that option.With
http-proxy, whentargetishttp://example.com/test, the request was proxied tohttp://example.com/test.But with
http-proxy-3, the request is proxied to ``http://example.com/test/` (has a trailing slash).This PR fixes that behavior difference by adding some code to handle them.
Since
req.url: ''doesn't happen normally, I'm also fine with patching this on Vite side (vitejs/vite#20679).